use staticfiles finders to find media files if STATIC_URL is defined #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my opinion, you shouldn't be doing this in production, because you should be using collectstatic and serving static files through your HTTP server or a static file service and not through Django itself. Not only is efficiency an issue, but this patch would only provide unneeded extra confusion to developers in debug mode - so, I believe that it is not helpful in production or debug environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.3 introduces staticfiles to store static app-specific media files. The files can be located in various locations around your project that you can define through your STATICFILES_FINDERS and STATICFILES_DIRS settings. This change uses the staticfiles finder to find the media files.