fix: check that all mappings are used

.github/workflows/main.yml

@@ -23,5 +23,7 @@ jobs:
         run: npm ci
       - name: Build
         run: npm run build
-      - name: Lint
-        run: npm run lint
+      - name: Check formatting
+        run: npm run lint:format
+      - name: Validate manifests
+        run: npm run lint:manifests

manifests/native.json

@@ -2402,6 +2402,11 @@
       "moduleName": "repeat-string",
       "replacements": ["String.prototype.repeat"]
     },
+    "safe-buffer": {
+      "type": "module",
+      "moduleName": "safe-buffer",
+      "replacements": ["safe-buffer"]
+    },
     "setprototypeof": {
       "type": "module",
       "moduleName": "setprototypeof",

scripts/validate-manifests.js

@@ -55,6 +55,8 @@ export async function validateManifests() {
       }
     }
 
+    const usedReplacementIds = new Set();
+
     for (const [key, mapping] of Object.entries(manifest.mappings)) {
       if (mapping.type === 'module' && mapping.moduleName !== key) {
         throw new Error(
@@ -68,6 +70,15 @@ export async function validateManifests() {
             `${manifestPath}: mapping "${key}" references unknown replacement "${replacementId}"`
           );
         }
+        usedReplacementIds.add(replacementId);
+      }
+    }
+
+    for (const id of Object.keys(manifest.replacements)) {
+      if (!usedReplacementIds.has(id)) {
+        throw new Error(
+          `${manifestPath}: replacement "${id}" is defined but not used by any mapping.`
+        );
       }
     }
   }