-
Notifications
You must be signed in to change notification settings - Fork 0
Switch to custom fc repo; Improve build system #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cd32ce8 to
8a130de
Compare
8a130de to
5da78a6
Compare
|
Not sure if FC tests should be run here or in the FC repo—in the FC repo, there might not be a way to enforce this as we will have multiple branches for versions, that won't be merged. But somehow requiring that all checks for the specific hash passed might work. EDIT: Adding CI status checks here and triggering tests on each push to the FC repo. |
… various states more robustly
.github/workflows/fc-versions.yml
Outdated
| contents: write | ||
|
|
||
| jobs: | ||
| # Run parallel builds via reusable workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho it would be cleaner to parse versions here, also semantically it make sense and just pass the version as an input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Note
Build pipeline now uses a custom Firecracker repo, parses versions into a matrix, builds in parallel, checks upstream CI, and conditionally uploads to GCS and creates per-version releases.
github/workflows/build.ymlto build a singleversion/hash/version_nameand upload artifact.fc-versions.yml:firecracker_versions.txtvia script; build using reusable workflow.main.version_name.build.shnow clonese2b-dev/firecracker, validates tag+hash, buildsfirecrackerbinary, and outputs tobuilds/<version_name>/.scripts/parse-versions-with-hash.shresolves versions to full hashes and normalizedversion_nameJSON.scripts/check-fc-ci.shinspects commit statuses/check-runs via GitHub API and reports pass/fail.README.mdto describe version parsing, matrix builds, CI gating, GCS upload, and releases; rename project tofc-versions.Written by Cursor Bugbot for commit d7b3db0. This will update automatically on new commits. Configure here.