Skip to content

Conversation

@ValentaTomas
Copy link
Member

@ValentaTomas ValentaTomas commented Dec 11, 2025

Note

Build pipeline now uses a custom Firecracker repo, parses versions into a matrix, builds in parallel, checks upstream CI, and conditionally uploads to GCS and creates per-version releases.

  • CI/Workflows:
    • Add reusable github/workflows/build.yml to build a single version/hash/version_name and upload artifact.
    • Revamp fc-versions.yml:
      • Add concurrency control.
      • Prepare matrix from firecracker_versions.txt via script; build using reusable workflow.
      • Check upstream CI for each commit; gate publishing on success and main.
      • Collect artifacts, upload to GCS, and create tagged GitHub releases per version_name.
  • Build:
    • build.sh now clones e2b-dev/firecracker, validates tag+hash, builds firecracker binary, and outputs to builds/<version_name>/.
  • Scripts:
    • scripts/parse-versions-with-hash.sh resolves versions to full hashes and normalized version_name JSON.
    • scripts/check-fc-ci.sh inspects commit statuses/check-runs via GitHub API and reports pass/fail.
  • Docs:
    • Update README.md to describe version parsing, matrix builds, CI gating, GCS upload, and releases; rename project to fc-versions.

Written by Cursor Bugbot for commit d7b3db0. This will update automatically on new commits. Configure here.

@ValentaTomas
Copy link
Member Author

ValentaTomas commented Dec 11, 2025

Not sure if FC tests should be run here or in the FC repo—in the FC repo, there might not be a way to enforce this as we will have multiple branches for versions, that won't be merged.

But somehow requiring that all checks for the specific hash passed might work.

EDIT: Adding CI status checks here and triggering tests on each push to the FC repo.

contents: write

jobs:
# Run parallel builds via reusable workflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho it would be cleaner to parse versions here, also semantically it make sense and just pass the version as an input

Copy link
Member Author

@ValentaTomas ValentaTomas Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@ValentaTomas ValentaTomas requested a review from jakubno December 11, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants