Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes eviction/removal behavior and sandbox state-transition coordination in both memory and Redis stores, which could impact lifecycle operations under concurrency. Risk is mitigated by explicit eviction gating and updated tests, but regressions could affect auto-pause/kill and cleanup paths.
Overview
This PR hardens sandbox eviction/removal to avoid races with in-flight state transitions and TTL extensions by introducing
sandbox.RemoveOpts(including anEvictionflag) and enforcing under-lock expiry/transition checks before evicting. It also standardizes sandbox-not-found handling viasandbox.ErrNotFound, updates orchestrator/handlers to use the new removal API, and makes the evictor treatErrNotEvictable/ErrNotFoundas expected outcomes rather than noisy failures.Written by Cursor Bugbot for commit 986f409. This will update automatically on new commits. Configure here.