Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| func (m JSONBStringMap) MarshalJSON() ([]byte, error) { | ||
| if m == nil { | ||
| return []byte("{}"), nil | ||
| } |
There was a problem hiding this comment.
The MarshalJSON override affects all JSON serialization of JSONBStringMap, not only DB persistence. Any API response structs embedding this type that previously returned null for absent metadata will now return {}. Clients distinguishing null (field absent/not set) from {} (explicitly empty) will see a behavioral change. Worth verifying no external API consumers rely on the null sentinel before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two layers:
Note
Medium Risk
Touches database trigger behavior and jsonb encoding for a shared type, which can affect how metadata is stored/queried across snapshot paths, but the change is narrowly scoped to normalizing
null/nil to{}.Overview
Prevents snapshot
metadatawrites from failing the NOT NULL constraint by updating the existingfix_snapshots_metadata_json_null()trigger to also coerce SQL NULL to{}, and by teachingtypes.JSONBStringMapto marshal nil maps as{}(and unmarshal JSONnullto an empty map), with tests covering the new serialization behavior.Written by Cursor Bugbot for commit 81631cd. This will update automatically on new commits. Configure here.