Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Button - New Component #1970

Closed
hej-wesley opened this issue Jan 3, 2023 · 9 comments
Closed

Toggle Button - New Component #1970

hej-wesley opened this issue Jan 3, 2023 · 9 comments

Comments

@hej-wesley
Copy link

hej-wesley commented Jan 3, 2023

This issue is for the creation of a Toggle Button component only. This would be the atomic piece of the Toggle Button Group component, which will be completed in the future. Issue Reference: #2060

Option list is a single & multi selection pattern that provides a more visual emphasis on the choices available. This documentation provides layout, behavior and content guidance for when and how to use an option list component.

Figma Link

@agliga agliga added this to eBayUI Jan 20, 2023
@agliga
Copy link
Contributor

agliga commented Jan 20, 2023

The link is taking me to the index page.
Can we have more details on this component?

@hej-wesley
Copy link
Author

@hej-wesley hej-wesley changed the title New Component - Option List New Component - Selection cell Jan 20, 2023
@agliga
Copy link
Contributor

agliga commented Jan 27, 2023

Still need to investigate. Looks like a good candiate to include.
Need a kickoff for this.

@agliga agliga added priority: 2 Fix should be on roadmap type: feature and removed blocked: design labels Mar 2, 2023
@agliga agliga added this to the 16.1.0 milestone Mar 2, 2023
@agliga agliga moved this to Todo in eBayUI Mar 2, 2023
@agliga
Copy link
Contributor

agliga commented Mar 2, 2023

Possibly do these as toggle buttons
Need to see if we can do deselecting of "radio" type so we can do it as toggle buttons properly.

@ianmcburnie
Copy link
Contributor

Tracking MIND pattern here: eBay/mindpatterns#99

@agliga agliga removed the status in eBayUI Apr 4, 2023
@agliga agliga moved this to Todo in eBayUI Apr 4, 2023
@agliga agliga modified the milestones: 16.1.0, 16.2.0 Apr 4, 2023
@ianmcburnie
Copy link
Contributor

Started MIND pattern documentation here: https://ebay.gitbook.io/mindpatterns/input/toggle-button-group

Still need to add working examples

@agliga
Copy link
Contributor

agliga commented Apr 21, 2023

We should call this toggle-button-group
Non form
Possibly use role-description
Show mobile version on <512px and then show side by side items.

Possibly need to check for stretching on large screens.

@agliga agliga changed the title New Component - Selection cell Selection cell - New Component Apr 21, 2023
@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Apr 24, 2023
@ArtBlue ArtBlue changed the title Selection cell - New Component Toggle Button Group - New Component Apr 24, 2023
@ArtBlue
Copy link
Contributor

ArtBlue commented Apr 28, 2023

I did quite a bit of research into the current state of affairs on container queries...

The Good News
From all indications, browser support appears to be complete for major browsers:

The Bad News

Based on the above, for now, I will be using a combination of grid, modifiers, and media queries to allow for different views and responsive variations.

@agliga agliga modified the milestones: 16.2.0, 16.3.0 May 10, 2023
@ArtBlue
Copy link
Contributor

ArtBlue commented May 12, 2023

There have been substantial changes to this since issue creation. Here's the new Figma link with updates: https://www.figma.com/file/zEBdEhbonrBOGzZ0fXzWvM/branch/dzliniXCfXwfkNR4Eu40l5/eBay-Design-System?type=design&node-id=101602-121185&t=Uz1ynDZKKJyq6l26-0

@ArtBlue ArtBlue changed the title Toggle Button Group - New Component Toggle Button - New Component May 12, 2023
@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI May 23, 2023
@ArtBlue ArtBlue closed this as completed Jun 15, 2023
@github-project-automation github-project-automation bot moved this from Pull request to Done in eBayUI Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants