Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Button Group - New Component #2060

Closed
ArtBlue opened this issue May 12, 2023 · 2 comments
Closed

Toggle Button Group - New Component #2060

ArtBlue opened this issue May 12, 2023 · 2 comments
Assignees
@ArtBlue
Labels
module: toggle-button-group type: feature
Milestone
16.5.0

Comments

@ArtBlue
Copy link
Contributor

ArtBlue commented May 12, 2023 •
edited
Loading

This introduces the Toggle Button Group that utilizes the atomic piece, Toggle Button component (#1970 ), to create a responsive layout.

Figma: https://www.figma.com/file/zEBdEhbonrBOGzZ0fXzWvM/branch/dzliniXCfXwfkNR4Eu40l5/eBay-Design-System?type=design&node-id=101602-121185&t=Uz1ynDZKKJyq6l26-0

Below is copied from dup issue...
Updated documentation for toggle button group.

Update name to “Toggle button group”
Added responsive layout section for guidance & clarity on max widths
Figma Link Here:
https://www.figma.com/file/zEBdEhbonrBOGzZ0fXzWvM/branch/dzliniXCfXwfkNR4Eu40l5/eBay-Design-System?type=design&node-id=101602%3A121185&t=oUa9vVc61zW1f7h3-1
@ArtBlue ArtBlue mentioned this issue May 12, 2023
Closed
@ArtBlue ArtBlue self-assigned this May 16, 2023
@agliga agliga added this to eBayUI May 17, 2023
@agliga
Copy link
Contributor

agliga commented May 17, 2023

Duplicate of #2059

@agliga agliga marked this as a duplicate of #2059 May 17, 2023
@agliga agliga added this to the 16.3.0 milestone May 17, 2023
@ArtBlue ArtBlue moved this to In Progress in eBayUI May 19, 2023
@agliga agliga mentioned this issue May 19, 2023
Closed
@ArtBlue
Copy link
Contributor Author

ArtBlue commented May 23, 2023

As discussed during a meeting, I attempted to use gap for the margins around buttons. Unfortunately, we can't use flex with gap for the buttons because the resulting layout is something that design does not want.
image

I'm reverting back to my initial implementation...

@ArtBlue ArtBlue modified the milestones: 16.4.0, 16.5.0 Jun 12, 2023
@ArtBlue ArtBlue moved this from In Progress to Todo in eBayUI Jun 20, 2023
@ArtBlue ArtBlue moved this from Todo to In Progress in eBayUI Jul 10, 2023
@ArtBlue ArtBlue mentioned this issue Jul 13, 2023
Merged
9 tasks
@ArtBlue ArtBlue moved this from In Progress to Pull request in eBayUI Jul 13, 2023
@ArtBlue ArtBlue moved this from Pull request to Done in eBayUI Jul 24, 2023
@ArtBlue ArtBlue closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtBlue ArtBlue

Labels
module: toggle-button-group type: feature
Projects
eBayUI
Status: No status
Milestone
16.5.0
Development

When branches are created from issues, their pull requests are automatically linked.

2060-toggle-button-group eBay/skin
2 participants
@ArtBlue @agliga