-
-
Notifications
You must be signed in to change notification settings - Fork 45
Compact no more #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compact no more #429
Conversation
Bumps [org.exist-db:exist-apps-parent](https://github.com/exist-db/exist-apps-parent) from 1.7 to 1.8. - [Release notes](https://github.com/exist-db/exist-apps-parent/releases) - [Commits](eXist-db/exist-apps-parent@1.7...1.8) Signed-off-by: dependabot[bot] <[email protected]>
…st-apps-parent-1.8 Bump org.exist-db:exist-apps-parent from 1.7 to 1.8
hold on a second the new test isn't executed that is strange: https://travis-ci.com/eXist-db/documentation/jobs/279810737#L428 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
<varlistentry> | ||
<term><code>resources</code></term> | ||
<listitem> | ||
<para>If <code>true</code> lists resources</para> | ||
<para>If <code>true</code> return a list of resources.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better if 'returns'
</listitem> | ||
</varlistentry> | ||
<varlistentry> | ||
<term><code>collections</code></term> | ||
<listitem> | ||
<para>If <code>true</code> lists collections</para> | ||
<para>If <code>true</code> return a list of collections.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem
<varlistentry> | ||
<term><code>name</code></term> | ||
<listitem> | ||
<para>Name of the new group.</para> | ||
<para>Takes thename of the new group.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space between "the" and "name".
Also, either 'groupname' here and in the following , or name in both cases. I see that you use 'username of the user' later on, so perhaps we want to keep groupname everywhere.
<varlistentry> | ||
<term><code>name</code></term> | ||
<listitem> | ||
<para>Name of the group to remove.</para> | ||
<para>Takes the groupname of the group to remove.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous note about consistency (groupname of the group/name of the group)
</listitem> | ||
</varlistentry> | ||
<varlistentry> | ||
<term><code>-d, --db</code></term> | ||
<listitem> | ||
<para>display general info about the db instance.</para> | ||
<para>Display general info about the db instance.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Displays
</listitem> | ||
</varlistentry> | ||
<varlistentry> | ||
<term><code>-h, --help</code></term> | ||
<listitem> | ||
<para>print help on command line options and exit.</para> | ||
<para>Print help on command line options and exit.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prints
<listitem> | ||
<para> while displaying server statistics: keep retrieving statistics, but | ||
wait the specified number of seconds between calls.</para> | ||
<para> while displaying server statistics: keep retrieving statistics, but wait the specified number of seconds between calls.</para> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keeps, waits
5e27c7d
to
ded7b85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, good to go.
Removes the ever troublesome compact variableList. Minor fixes in various articles.
ToC generation now works with inline elements, and has a test.
Close #425