Skip to content

Compact no more #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 24, 2020
Merged

Compact no more #429

merged 10 commits into from
Jan 24, 2020

Conversation

duncdrum
Copy link
Contributor

Removes the ever troublesome compact variableList. Minor fixes in various articles.

ToC generation now works with inline elements, and has a test.

Close #425

@duncdrum duncdrum requested a review from a team January 24, 2020 16:35
@duncdrum
Copy link
Contributor Author

duncdrum commented Jan 24, 2020

hold on a second the new test isn't executed that is strange: https://travis-ci.com/eXist-db/documentation/jobs/279810737#L428

Copy link
Contributor

@lguariento lguariento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

<varlistentry>
<term><code>resources</code></term>
<listitem>
<para>If <code>true</code> lists resources</para>
<para>If <code>true</code> return a list of resources.</para>
Copy link
Contributor

@lguariento lguariento Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if 'returns'

</listitem>
</varlistentry>
<varlistentry>
<term><code>collections</code></term>
<listitem>
<para>If <code>true</code> lists collections</para>
<para>If <code>true</code> return a list of collections.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

<varlistentry>
<term><code>name</code></term>
<listitem>
<para>Name of the new group.</para>
<para>Takes thename of the new group.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space between "the" and "name".

Also, either 'groupname' here and in the following , or name in both cases. I see that you use 'username of the user' later on, so perhaps we want to keep groupname everywhere.

<varlistentry>
<term><code>name</code></term>
<listitem>
<para>Name of the group to remove.</para>
<para>Takes the groupname of the group to remove.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous note about consistency (groupname of the group/name of the group)

</listitem>
</varlistentry>
<varlistentry>
<term><code>-d, --db</code></term>
<listitem>
<para>display general info about the db instance.</para>
<para>Display general info about the db instance.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Displays

</listitem>
</varlistentry>
<varlistentry>
<term><code>-h, --help</code></term>
<listitem>
<para>print help on command line options and exit.</para>
<para>Print help on command line options and exit.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prints

<listitem>
<para> while displaying server statistics: keep retrieving statistics, but
wait the specified number of seconds between calls.</para>
<para> while displaying server statistics: keep retrieving statistics, but wait the specified number of seconds between calls.</para>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keeps, waits

Copy link
Contributor

@lguariento lguariento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, good to go.

@lguariento lguariento merged commit 409d1b8 into eXist-db:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants