Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump gulp-sass from 4.1.0 to 5.0.0 #657

Merged
merged 6 commits into from
Sep 29, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 28, 2021

Bumps gulp-sass from 4.1.0 to 5.0.0.

Release notes

Sourced from gulp-sass's releases.

v5.0.0

First and foremost a huge shout out to @​mxmason for making this long awaited release possible <3

Breaking changes

  • Require Node >= 12
  • Require Gulp 4
  • Drop dependency on the deprecate node-sass
  • Remove hardcoded default Sass compiler

Upgrading to v5

It is now required to explicitly install a Sass compiler.

npm install gulp-sass sass

or to continue using node-sass

npm install gulp-sass node-sass

Gulp tasks will also need to be update to use the installed Sass compiler

const sass = require('gulp-sass')(require('sass'));

Check out the upgrade guide for more details.

v4.1.1

Dependencies

Changelog

Sourced from gulp-sass's changelog.

v5.0.0

June 25, 2021 https://github.com/dlmanning/gulp-sass/releases/tag/v5.0.0

v4.1.1

June 24, 2021 https://github.com/dlmanning/gulp-sass/releases/tag/v4.1.1

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 28, 2021
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/gulp-sass-5.0.0 branch from c865db6 to 020b9ae Compare July 19, 2021 18:24
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once the necessary changes are in, this would warrant a patch release imv.

Bumps [gulp-sass](https://github.com/dlmanning/gulp-sass) from 4.1.0 to 5.0.0.
- [Release notes](https://github.com/dlmanning/gulp-sass/releases)
- [Changelog](https://github.com/dlmanning/gulp-sass/blob/master/CHANGELOG.md)
- [Commits](dlmanning/gulp-sass@v4.1.0...v5.0.0)

---
updated-dependencies:
- dependency-name: gulp-sass
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/gulp-sass-5.0.0 branch from 020b9ae to 7e1278e Compare September 28, 2021 07:58
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@line-o
Copy link
Member

line-o commented Sep 29, 2021

So we are still not linting test files because of #628?

@line-o line-o merged commit adb0e10 into master Sep 29, 2021
@line-o line-o deleted the dependabot/npm_and_yarn/gulp-sass-5.0.0 branch September 29, 2021 10:27
@duncdrum
Copy link
Contributor

So we are still not linting test files because of #628?

yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help-wanted javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants