Skip to content

Improve security and configurability of functions that access the Environment and System Properties #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Improve security and configurability of functions that access the Environment and System Properties #4452

wants to merge 11 commits into from

Conversation

adamretter
Copy link
Contributor

Forward port of #4449

@adamretter adamretter added bug issue confirmed as bug enhancement new features, suggestions, etc. labels Jun 21, 2022
@adamretter adamretter added this to the eXist-6.1.0 milestone Jun 21, 2022
@adamretter adamretter requested a review from a team June 21, 2022 15:16
@line-o line-o added the needs documentation Signals issues or PRs that will require an update to the documentation repo label Jun 22, 2022
@adamretter
Copy link
Contributor Author

@line-o There is some documentation for this in the conf.xml file now. If you think there should also be some for the website, could you let me know where you think it should go and then I will try and add something

adamretter added 11 commits August 3, 2022 21:39
@adamretter
[ignore] Reformat code
a6b551a
@adamretter
[ignore] Fix Typo
614b5ef
@adamretter
[bugfix] fn:available-environment-variables and fn:environment-variab…
21c5f6b 
…le should be deterministic within the execution scope
@adamretter
[bugfix] Make thread-safe
27040ca
@adamretter
[refactor] Rename class to ExistSystemProperties to make it clear the…
f3847e1 
…se are not Java System Properties
@adamretter
[refactor] Use constants for eXist-db System Properties
b1f1abd
@adamretter
[bugfix] util:system-property should be deterministic within the exec…
e5ead3a 
…ution scope
@adamretter
[feature] Add the function util:available-system-properties#0
4d6d46a
@adamretter
[feature] Allow access to specific Environment Variables when using f…
475cab8 
…n:available-environment-variables#0 and fn:environment-variable#1 to be configured from conf.xml
@adamretter
[feature] Allow access to specific Java System Properties when using …
cc67d13 
…fn:available-system-properties#0 and fn:system-property#1 to be configured from conf.xml
@adamretter
[bugfix] Adjust test for Windows
7c2c499
@adamretter adamretter force-pushed the feature/security/env-prop branch from 5ca5381 to 7c2c499 Compare August 3, 2022 19:59
@adamretter adamretter marked this pull request as draft August 15, 2022 17:45
@adamretter
Copy link
Contributor Author

Found an issue that I need to fix...

@adamretter adamretter modified the milestones: eXist-6.1.0, eXist 6.2.0 Jan 15, 2023
@adamretter adamretter modified the milestones: eXist 6.2.0, eXist-7.1.0 Feb 4, 2023
@line-o
Copy link
Member

line-o commented Aug 3, 2025

I assume this PR contains important changes to exist-db that we should pull in after finalising.
@adamretter would you still happen to know what needed fixing here?

@adamretter
Copy link
Contributor Author

@line-o Sure, just run the changes and the test suite you will see the issue clearly I think, let me know if you don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug issue confirmed as bug enhancement new features, suggestions, etc. needs documentation Signals issues or PRs that will require an update to the documentation repo
Projects
None yet
Milestone
eXist-7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adamretter @line-o