WiFiServer modernization #1871
Merged
WiFiServer modernization #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAndrassy
force-pushed
the
wifiserver_modern
branch
from
d54c4e1 to
b2a994b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In new (this year's) WiFi libraries by Arduino in the Renesas Core they finally enhanced the WiFiServer API so now we know that the preferred method name to stop the server is
end. They addedbeginwith parameterportwhich goes with a constructor without parameter.op bool for Server originates in the Ethernet library 2018 update.
And I recommend to mark method
available()as deprecated. Users should be educated to useaccept()as this is the correct name for that implementation.