PIOProgram: Replace __pioHighGPIO with pio_get_gpio_base() #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlephilhower
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2768
I've also changed
needsHigh(trueorfalse) togpioBaseNeeded(0or16) to help simplify some of the checks and prints later on. This matches the original behavior ofPIOProgram.cpp(at least as far as my quick test showed), though I think it may be better to change it to some kind of tertiary behavior, because GPIO base 0 and 16 are both valid for GPIO 16-31. But that's an optimization better had in a different PR, because this is just meant to be a bug fix.