Skip to content

Port DefinedTerm keyword fix (#219) from master into dev - #287

Merged
ywkim312 merged 1 commit into
devfrom
feature/286-bring-definedterm-keyword-fix-219-from-master-into-dev
Jul 27, 2026
Merged

Port DefinedTerm keyword fix (#219) from master into dev#287
ywkim312 merged 1 commit into
devfrom
feature/286-bring-definedterm-keyword-fix-219-from-master-into-dev

Conversation

@ywkim312

@ywkim312 ywkim312 commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Port the DefinedTerm keyword rendering fix from master (#219) into dev, so BODC-style keyword objects display as names/links instead of broken object output.

This does not re-apply #279 / fix/278 (Docker/Vue peer-dependency fix). dev already has Vue 3.5 and a yarn-based Dockerfile.

@valentinedwv This change is already on master via #219. Bringing it into dev now should reduce the chance of losing the DefinedTerm keyword fix (or hitting a painful conflict) later when we merge dev → master.

#279 / the Docker+Vue fix is intentionally not included here — dev already has that stack.

Since you already reviewed/approved #219 on master, a quick re-approve + merge of this PR into dev would be appreciated. Thanks!

Changes

  • Update dataset.vue to handle string and DefinedTerm keywords (name + optional URL)
  • Add providers rendering support from #219
  • Update Blazegraph SPARQL keyword patterns to support literal keywords and DefinedTerm name
  • Add config_qlever_test.yaml
  • Allow env overrides for local API_URL / JSONLD_PROXY in development.js
  • Ignore root .env in .gitignore

Test plan

  • Open a dataset with DefinedTerm keywords and confirm names render (and links when URL/@id exists)
  • Confirm plain string keywords still render normally
  • Confirm providers section renders when provider data exists
  • Confirm no Dockerfile / package.json / yarn.lock changes in this PR

@ywkim312 ywkim312 linked an issue Jul 27, 2026 that may be closed by this pull request
6 tasks
@ywkim312
ywkim312 requested review from lmarini and valentinedwv July 27, 2026 18:15
@ywkim312 ywkim312 self-assigned this Jul 27, 2026
@ywkim312
ywkim312 merged commit a9a0f63 into dev Jul 27, 2026
3 checks passed
@ywkim312
ywkim312 deleted the feature/286-bring-definedterm-keyword-fix-219-from-master-into-dev branch July 27, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring DefinedTerm keyword fix (#219) from master into dev

2 participants