Update easyblocks to use EasyConfig.parallel property
#3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use the deprecated `ec['parallel']` value anymore. Introduce a property to `ConfigureMake` to get the commonly used `-j <n>` string. Verify each use converting them to fStrings.
Flamefire
force-pushed
the
parallel_prop
branch
from
0bafa27 to
c0bdf64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the deprecated
ec['parallel']value anymore.Introduce a property to
ConfigureMaketo get the commonly used-j <n>string.Verify each use converting them to fStrings. Partially because it makes it easier to read but also to let me verify I had checked every place where it is used.
Requires
paralleleasyconfig parameter and fix updating the template value easybuild-framework#4580