Restructure RPATH and elf interpreter setting for Java, and add the LIBRARY_PATH to the additional RPATH #3571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2025 22:55
…IBRARY_PATH to the additional RPATH
|
To get a baseline, these are the current headers and build logs for a library ( and from the build logs The same thing for a binary: And the build log: |
|
After building with: I get the same (as expected): and for Great, means we have retained the old behavior throughout the restructuring of the code. Next, we try with an Easyconfig at the GCCcore level which has X11 as dependency. This should make sure that the Clearly, that is not right: a properly RPATH-ed library should be able to find all its dependencies. |
|
Just as a test: Installing this: With that, the X11 libraries, including Note that |
|
Installing with We now get: That looks completely fine, now everything is found. |
|
Next step, I'll make some GCCcore based java easyconfigs, that can utilize this Easyblock PR properly |
added 5 commits
January 30, 2025 02:31
…kipping it unconditionally
…tching of the RPATH for java now
|
I'm... confused. To test the RPATH sanity check, I removed the X11 dependency in my Easyconfig file. I see Why doesn't this result in a failed sanity check? Edit: I may know, I probably should have returned the values from the RPATH sanity check step, as those are the failure message. I.e. the function |
|
Ok, so even with the correct deps, it is failing, because my patchelf sets |
|
Ok, this is for tomorrow to solve: some library is still not found in the RPATH: |
|
Ooff, Java is messy: The reason there is no RPATH is because this is an executable that is located in I see two options here: either I find all files under Right now, there are only two files that this concerns, so I think hardcoding is the way to go here. The good news is that if an additional executable ends up in |
|
Hm, we actually do the checking for dynamically linked executables for the RPATH sanity check. So maybe it's not too expensive. I'll just do that instead, it'll be more robust and we can spare the extra few seconds. |
|
Hm, I think we can improve here:
|
|
Hm, I think we can improve here:
|
added 2 commits
January 30, 2025 18:27
added 12 commits
January 30, 2025 18:29
…y returns something :)
…g extra RPATHS. Also, fix syntax for call to logging
…Also, set bin_lib_subdirs so that also the files in lib/server are patched
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in fixing the issue observed here with Aladin-desktop that certain libraries aren't properly RPATH-ed, and as a result, the relevant X11 library cannot be found. The reason is that
easybuild-easyconfigs.