{geo}[gompi/2024a] WRF-SFIRE vW4.4-S0.1 w/ dmpar

[hvelab]

(created using eb --new-pr)

this was requested to be incorporated on EESSI, removing the "time" command is because the compat layer doesn't ship it and makes the build to crash, for what I saw online could be a problem for users with different flavours of linux so maybe not too bad to leave it there?

any better suggestion on how to handle this is welcome

[boegel]

@hvelab Just wondering: did you consider leveraging the existing WRF easyblock?

Not sure if that makes any sense at all in this case...

[boegel]

@boegelbot please test @ jsc-zen3

[boegelbot]

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=25506 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_25506 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

• exit code: 0
• output:

Submitted batch job 9946

Test results coming soon (I hope)...

Details

- notification for comment with ID 4004250028 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

[boegelbot]

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (total: 2 mins 32 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.7, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/8925ec5a8b8a05a746aeb4a01db56786 for a full test report.

[hvelab]

@hvelab Just wondering: did you consider leveraging the existing WRF easyblock?

Not sure if that makes any sense at all in this case...

You mean to create a new one with the fix? I am not sure for this case it makes much sense. As it is for EESSI we could just move it to the hooks

[boegel]

Ooof, this is quite cryptic (so is the sed command above).

Any chance we can make this more readable, or use a patch file, or at the very least break it down step-by-step and adding comments?

[hvelab]

just added a cleaner look with the commented options on how would it look if we did it with a patch, thing is using a patch is not trivial as it needs to be applied right afte the configure step and im not sure if it will be the same patch for all architectures, the ways of the configure.wrf file are complicated

[boegel]

@hvelab Can you look into fixing the code style issues that are causing CI to fail?

 /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/w/WRF-SFIRE/WRF-SFIRE-W4.4-S0.1-gompi-2024a-dmpar.eb:57:1: E265 block comment should start with '# '
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/w/WRF-SFIRE/WRF-SFIRE-W4.4-S0.1-gompi-2024a-dmpar.eb:59:9: E117 over-indented