{data}[gfbf/2023b] scikit-learn v1.6.1, meson-python v0.16.0, Meson v1.4.0 - #26307
{data}[gfbf/2023b] scikit-learn v1.6.1, meson-python v0.16.0, Meson v1.4.0#26307PhoenixEmik wants to merge 9 commits into
Conversation
Updated software
|
|
Test report by @PhoenixEmik |
|
Test report by @PhoenixEmik |
|
Got an error that didn't happened before: |
|
Test report by @PhoenixEmik |
Updated software
|
|
Test report by @PhoenixEmik |
Removed obsolete sklearn version and checksums.
|
Test report by @PhoenixEmik |
Flamefire
left a comment
There was a problem hiding this comment.
This could use existing Meson & meson-python.
Besides that I added some comments which is just what seemed odd to me while reading
| easyblock = 'PythonBundle' | ||
|
|
||
| name = 'meson-python' | ||
| version = '0.16.0' |
There was a problem hiding this comment.
Do you need 0.16 specifically? We already have 0.15
There was a problem hiding this comment.
I bump scikit-learn to 1.6.1 which uses meson-python 0.16.0 in other easyconfigs.
There was a problem hiding this comment.
Yes but those use a different toolchain (2023a, 2024a instead of 2023b), so they are likely to use different dependency versions: They use what is already available in their toolchain.
I see @verdurin introduced an additional meson-python to for the 2023a toolchain as dependency for scikit-learn in #22698 Maybe he remembers why?
| ] | ||
|
|
||
| exts_list = [ | ||
| ('pyproject-metadata', '0.8.0', { |
There was a problem hiding this comment.
I think this should go into an easyconfig. We have many modules installing this possibly redundantly and maybe conflicting. Counts per toolchain
1 foss-2023b.eb
1 GCCcore-12.2.0.eb
8 GCCcore-12.3.0.eb
5 GCCcore-13.2.0.eb
4 GCCcore-13.3.0.eb
6 GCCcore-14.2.0.eb
6 GCCcore-14.3.0.eb
2 GCCcore-15.2.0.eb
1 gfbf-2023a.eb
1 gfbf-2023b.eb
1 gfbf-2024a.eb
1 gfbf-2025a.eb
1 gfbf-2025b.eb
1 iimkl-2023a.eb
1 iimkl-2025b.eb
There was a problem hiding this comment.
I agree with that. Maybe propose in next conference call?
|
Thanks, I really appreciate the review. Actually I forget why I used such versions... |
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
|
Test report by @PhoenixEmik |
Existing easyconfigs from different toolchains? Then you should check for existing (dependency) easyconfigs in the current toolchain first and try those. IIRC |
I remember |
I usually use it like this: |
Thank you for guiding me. It sounds good. I may close this PR and #25784 for now. |
|
Test report by @Flamefire |
|
I just tested this with the existing meson-python:
The current one passes, see above So 1.6.1 really requires a newer meson-python. That was the missing piece. |
(created using
eb --new-pr)