-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync with develop (20240915) #4639
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l URLs. Add the --extra-source-urls CLI option, a | separated list of URLs that EasyBuild will fetch sources from. It replaces the hard-coded EASYBUILD_SOURCES_URL, but keeps it as a default value. Uses the add_flex logic to prepend, append, or insert into the default list. Co-authored-by: Alexander Grund <[email protected]>
For some modules the sanity check command(s) fail when run in the build environment. This option can be used to still install it and investigate later.
`GNU_SOURCE` (https://ftpmirror.gnu.org/gnu) is sometimes unreachable. We can use the main source instead of the mirror: https://ftp.gnu.org/gnu Add the constant `GNU_FTP_SOURCE` for that. Recommended use: `source_urls = [GNU_SOURCE, GNU_FTP_SOURCE]`
The test searches for the real command, e.g. `gcc`, deletes the first one found and uses the rest. However there could be multiple ones: /usr/bin/gcc /bin/gcc In this case the second would be wrongly used as the input. Fix by converting the output of `which` into an array and using the 2nd entry.
The current "No software-specific easyblock 'EB_UNKNOWN' found for UNKNOWN" is rather confusing. Don't use UNKNOWN and just error/handle it.
Provide a better error message in case the EassyConfig file doesn't contain anything but whitespace.
Checksums for post-install patches come after the patch checksums, see `fetch_patches`. As those were not included in the check specifying a checksum for those patches leads to errors such as > found 0 sources + 0 patches vs 1 checksums
This is from the python installation since 2.7
Use recent version of keyrings Remove redundant stuff Reordering
This use case comes up with e.g. `--copy-ec /tmp`. The existing code will see that `/tmp` exists and has a different UID and hence will use `shutil.copy_file` which expects the target to not be a folder. It hence fails with "[Errno 21] Is a directory" Use `shutil.copy` as was likely intended anyway.
`shutil.copy` tries to change permissions which isn't allowed in the case where it is used. As we already made sure the target is a file we can use `shutil.copyfile`
The current one is not clear enough as to what `<ext>` is supposed to be. So provide some examples, especially `.dot` which doesn't require `graphviz-python`
…ting whether specifying it here fixes the tests.
…NE so that init_config has the right default value. Should fix CI tests.
…late add `GNU_FTP_SOURCE` template constant
…_cache fix `test_compiler_cache`
improve error messages for empty EasyConfigs
…checksums handle post-install patches in check_checksums_for
fix `copy_file` with a folder as the target
improve help string for `--dep-graph`
only call `_sanity_check_step_extensions` if `--skip-extensions` is not set
allow for case where `homepage = None` when generating the docs
Add support for `--software-commit` and an associated template `%(software_commit)s`
…ption add support for `--extra-source-urls` to fetch sources from additional URLs
The dots usually indicate some upcoming process or shortened information. Neither is true at this point: The backup file *has* been saved. Removing the dots makes it also easier to C&P the resulting name as the selection will no longer automatically contain the dots.
Remove trailing dots from backup message.
prepare release notes for EasyBuild v4.9.3 + bump version to 4.9.3
…commit_status fix `test_github_det_commit_status` by using more recent commits
release EasyBuild v4.9.3
sync with main + bump version to 4.9.4dev
branfosj
reviewed
Sep 15, 2024
Co-authored-by: Simon Branford <[email protected]>
branfosj
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.