Replace obsolete isinff(...) #276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You included a release commit; please, rebase instead of merging from the main development branch. Additionally, the reason why #188 was not merged is that it breaks the tests of one of the SIMD implementations. |
Oh I am so sorry, I will then fix the problem soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # N/A
Proposed changes: Replace
isinff(...)with a combination ofisinf(...)andsignbit(...)Benchmark results: No changes in performance.
Test suite changes: N/A
Almost the same to #188, but more aggressive.
isinff(...)is completely remove from the source tree.Reason: Mentioned in PR188,
isinff(...)is both obsolete and non-standard. To maximized portability and suggested by GNU, we should have it replaced.