Windows Struct Support: Organization + Tests can build a DLL #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My first implementation failed, but this was the first step to get things building/testable. I'll give it a second go tomorrow with fresh eyes |
| "testing" | ||
| "unsafe" | ||
|
|
||
| "github.com/ebitengine/purego" | ||
| "github.com/ebitengine/purego/internal/load" | ||
| ) | ||
|
|
||
| func getSystemLibrary() (string, error) { |
There was a problem hiding this comment.
I think this can stay here instead of moving it to a separate file
| @@ -186,41 +162,3 @@ func TestABI(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I would also keep this here and just modify it to support windows. The reason is it is also used by Linux so if it's pulled out it'd create another file which isn't necessary
| @@ -3,43 +3,52 @@ | |||
|
|
|||
| #include "stdint.h" | |||
|
|
|||
| #if defined(__x86_64__) || defined(__aarch64__) | |||
| #if defined(__x86_64__) || defined(__aarch64__) || defined(_WIN32) | |||
There was a problem hiding this comment.
Why specifically add the windows check is it not x86 or arm?
| // Empty is empty | ||
| struct Empty {}; | ||
| struct Empty; |
There was a problem hiding this comment.
Why remove the braces?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Closes #237
What type of issue is this addressing?
Feature
What this PR does | solves
Adds struct parameter and return support for Windows (amd64)