Skip to content

Conversation

lionnel
Copy link

@lionnel lionnel commented Oct 7, 2020

Hi,

I'have isolated the initializeProxy to be able to set environment http.proxyUrl, http.proxyUser & http.proxyPassword to be able to pass local proxy.

@ebourg
Copy link
Owner

ebourg commented Oct 12, 2020

Thank you for the suggestion, but is this really necessary? The JVM automatically picks the http.proxy* system properties to configure the proxy. We shouldn't have to redo the same work here.

@lionnel
Copy link
Author

lionnel commented Oct 12, 2020

Yes the JVM take account of proxy url (host and port).
But as far as I have checked it do not take account of the user/password part.
No pb if you do not merge the pr.
I'm trying to implement a verifier. As I work being an authenticate proxy, it's more to me to be sure not to push this part in the future pr.
Regards

@ebourg
Copy link
Owner

ebourg commented Oct 12, 2020

The username/password properties should be used automatically, at least with Java 8:

https://stackoverflow.com/questions/1626549/authenticated-http-proxy-with-java

Also if you work behind a proxy, you may want to try -Djava.net.useSystemProxies=true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants