-
Notifications
You must be signed in to change notification settings - Fork 131
Add Upwind Security Case Study #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for ebpfio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Chris! Good to see you here!
It looks like the JSON is malformed - there's a missing opening quote before the URL, and some closing delimiters have also been removed. Can you fix, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You as well @qmonnet! Should be all set now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No sorry, the JSON is still malformed (look at least at the very last delimiter). It might be worth running the file in a JSON validator (there are plenty online).
Please note that other case studies have translations for the other supported languages, and they seem to have their own logo. I've not worked on them closely, but take a look at https://github.com/ebpf-io/ebpf.io-website/pull/669/files for an example
Once this merge goes through, I'll copy/paste submit for the other languages. |
No please, let's do them all in this PR. I've no doubt you intend to follow up, but in my experience this is typically the sort of things that fall through, once the “main” part is merged and when other priorities come in the way. |
Should be all set. Let me know if you need a bigger logo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding the translations!
There are still a few issues to fix, see below.
Can you also please squash your commits into a single one? It's not really necessary to keep one commit per language + fixes.
Regarding the size of the logo, it's SVG so it should scale; but I don't have permissions to trigger the Netlify preview build, and I haven't been as far as fixing the JSON to check the preview locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed formatting and typo. I don't have Git locally, squashing the commits will take me a second as I don't believe there's a way to squash them in the GUI
Added Upwind Security [ Quentin: Fixed JSON, formatting, squashed commits ] Signed-off-by: clentricchia <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have not fixed the JSON, or the formatting. Let me fix them for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should now be OK. Chris, please pull the current branch first if you need to change the PR.
I've not checked all translation texts individually.
Leaving it to someone who can trigger the preview to validate and merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@paularah can you please trigger the Netlify preview build? I'd like to make sure the logo renders correctly |
I just looked at the blog and it only talks about eBPF for security generally and now about how the upwind product uses it. Do you have a better link? It would also be great if you could add a logo so it matches all of the other ones. |
Co-authored-by: Bill Mulligan <[email protected]> Signed-off-by: clentricchia <[email protected]>
Hey @xmulligan, This blog might be a better fit for what you're looking for: https://www.upwind.io/feed/leveraging-ebpf-for-devsecops Will update the logo. |
Signed-off-by: clentricchia <[email protected]>
@clentricchia that blog post is closer, but it still doesn't say how upwind actually uses eBPF. Do you have a blog that does? |
@xmulligan not at the moment, but in a month or so, I will have a better blog for you that does |
Ok, let's leave this PR open until that gets published and you can update the link once it is out |
Added Upwind Security to case studies