Skip to content

Conversation

@yashkhokhar28
Copy link
Contributor

Which issue does this PR close?


Rationale for this change

  • Existing social media icons were outdated and inconsistent with current branding.
  • The X (Twitter) icon had visibility issues in both light and dark themes.
  • Phone numbers were plain text, preventing users on mobile devices from directly calling via the dialer.
  • Updating icons + adding tel: support improves UX, accessibility, and consistency.

What changes are included in this PR?

  • Replaced outdated social media icons with updated versions from react-icons/fa6.
  • Fixed X (Twitter) icon visibility for both light and dark themes.
  • Corrected incorrect usage of <img src={icon}> by rendering icons directly as React components.
  • Added tel: links for phone numbers to enable mobile redirection to the dialer app.
  • Retained mailto: support for email links.
  • Improved hover interactions for icons (hover:text-blue-500 and dark:hover:text-orange-400).
  • Standardized sizing with text-2xl for consistent scaling across icons.

Are these changes tested?

  • ✅ Manual testing performed on desktop (Chrome, Firefox) and mobile (Android & iOS).
  • ✅ Verified that icons render correctly in both light and dark themes.
  • ✅ Confirmed hover states are applied.
  • ✅ Confirmed mailto: opens default mail client.
  • ✅ Confirmed tel: link opens dialer on mobile devices.

Are there any user-facing changes?

  • Yes

    • Icons are now updated to the latest versions, making them visually consistent with brand guidelines.
    • X (Twitter) icon is now clearly visible in both light and dark modes.
    • Phone numbers are now clickable on mobile → redirect to the dialer app.
image

@vercel
Copy link

vercel bot commented Aug 28, 2025

@yashkhokhar28 is attempting to deploy a commit to the eccentriccoder01's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
saralseva Ready Ready Preview Comment Aug 29, 2025 6:29am

@eccentriccoder01
Copy link
Owner

Great work again @yashkhokhar28!

@eccentriccoder01 eccentriccoder01 merged commit fc26668 into eccentriccoder01:main Aug 29, 2025
3 of 5 checks passed
@yashkhokhar28 yashkhokhar28 deleted the fix/social-icons-and-tel-link branch August 29, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc25 level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug : X (Twitter) icon visibility issue + Email redirection inconsistency

2 participants