Skip to content

Remove event emission from flow_raw2Sv #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leewujung merged 1 commit into from
Aug 24, 2026
Merged

Remove event emission from flow_raw2Sv #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/echodataflow/flows/flows_acoustics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
from prefect.futures import as_completed
from prefect.states import Failed
from prefect import runtime
from prefect.events import emit_event

from echodataflow.deployment.task_runners import dask_task_runner_from_environment
from echodataflow.utils.manifests import (
Expand Down Expand Up @@ -228,15 +227,6 @@ async def set_failed_state():
asyncio.run(set_failed_state())
raise Exception(error_msg)

emit_event(
event="echodataflow.sv.updated",
resource={
"prefect.resource.id": "sv-monitor",
"prefect.resource.name": "sv-monitor",
},
)


@flow(log_prints=True)
async def flow_create_MVBS(
time_offset_seconds: float = 0.0,
Expand Down
10 changes: 5 additions & 5 deletions tests/deployment/test_deploy_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,23 +124,23 @@ def test_build_deploy_specs_passes_target_flow_parameters_directly(install_prefe
engine = importlib.import_module("echodataflow.deployment.deployment_engine")

specs = engine.build_deploy_specs(
param_cfg={"flows": {"emit_event_ABC": {"msg": "hello"}}},
param_cfg={"flows": {"raw2Sv": {"path_main": "/data"}}},
deploy_cfg={
"flows": {
"emit_event_ABC": {
"raw2Sv": {
"interval": 1,
}
}
},
resolved_flows={
"emit_event_ABC": {
"raw2Sv": {
"flow_obj": object(),
"entrypoint": "echodataflow/flows/flows_test.py:flow_emit_event_ABC",
"entrypoint": "echodataflow/flows/flows_acoustics.py:flow_raw2Sv",
}
},
)

assert specs[0].parameters == {"msg": "hello"}
assert specs[0].parameters == {"path_main": "/data"}


def test_build_deploy_specs_preserves_runner_and_concurrency_group(install_prefect_stubs):
Expand Down