Taxii2 major Bug fixes and enhancements for production use #272
Conversation
- Added example on how to define accounts with permissions for taxii2 and taxii1. - Fixed authentication for taxii2. Now accounts can be defined to access private collections with 'read' or 'modify' access.
When a collection that does not exist is used in a data-configuration file, a warning is produced
If no credentials are provided and you try to access a public collection, there is an error. Now it has been fixed.
Also expanded the example for taxii2 data-configuration-accounts
The script can be used to test push, pull, and subscribe functionality with taxii2-client
docker-compose.yml was missing version and services.
There was a problem hiding this comment.
Thank you very much for your contributions. There are many unrelated changes. I would prefer to split the changes in multiple MRs:
This PR includes all changes from #267.
See #267 (review)
Support of default_pagination_limit and max_pagination_limit parameters for manifest and objects get endpoints to avoid errors because of large response size.
See #278 (review).
Fixed opentaxii-create-account command to support admin argument.
Fixed with #294
Fixed add_objects method to define modified time and spec_version parameters if not provided in POST data.
Fixed delete object operation to delete objects from database.
Fixed by #275
Bug fix to return correct spec_version value in response instead of object type
Fixed by #276
| print('cannot find account with given username') | ||
|
|
||
|
|
||
| def delete_account(argv=None): |
There was a problem hiding this comment.
Good idea. If you could open a dedicated PR with a test, it could be merged.
| except ImportError: | ||
| from sqlalchemy.ext.declarative import DeclarativeMeta | ||
|
|
||
| selected_db = None |
|
Sorry for the late review, and thank you for your contributions. In the meantime, a lot of fixes have already landed and for the remaining items I would prefer dedicated PRs to simplify the review process. In any case, a good description of the change and new/updated tests are a requirement. |
3 participants
This PR includes all changes from Open PR by aams-eam.
Other bug fixes and enhancements:
default_pagination_limitandmax_pagination_limitparameters formanifestandobjectsget endpoints to avoid errors because of large response size.opentaxii-create-accountcommand to supportadminargument.add_objectsmethod to define modified time andspec_versionparameters if not provided in POST data.spec_versionvalue in response instead of object type.