sdk: Refactor AbstractObjectProvider #430
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `AbstractObjectProvider` only worked with `Identifiables`, which made it incompatible with the new version of the AAS metamodel. This renames and restructures both the `AbstractObjectProvider` and the `AbstractObjectStore`. In all non-abstract subclasses where `Object` appears in the class or method name, it has been replaced with `Identifiable`. Old classes are still available with a deprecation warning. Moreover, `AbstractObjectProvider` and `AbstractObjectStore` are now generic to be able to handle more classes than just `Identifiables`. In order to handle the new `AASDescriptor`, a new class `HasIdentifier` has been added. It is intended to be an abstract superclass for all classes that have an identifier, but are not `Identifiables`. As of now, this PR is intended to serve as a basis for discussion. Therefore, the documentation has not yet been adapted. Fixes eclipse-basyx#428
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
AbstractObjectProvideronly worked withIdentifiables, which made it incompatible with the new version of the AAS metamodel.This renames and restructures both the
AbstractObjectProviderand theAbstractObjectStore. In all non-abstract subclasses whereObjectappears in the class or method name, it has been replaced withIdentifiable. Old classes are still available with a deprecation warning.Moreover,
AbstractObjectProviderandAbstractObjectStoreare now generic to be able to handle more classes than justIdentifiables.In order to handle the new
AASDescriptor, a new classHasIdentifierhas been added. It is intended to be an abstract superclass for all classes that have an identifier, but are notIdentifiables.As of now, this PR is intended to serve as a basis for discussion. Therefore, the documentation has not yet been adapted.
Fixes #428