Remove parenthesis cleanup & extra getFullPathExpression() calls #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to catch error when casting a variable to another type
The total removal of parenthesis removes casting parenthesis and breaks potential watch expressions so this cleanup should be removed. Instead of calling getFullPathExpression() multiple times, build the fullPath from the topLevelExpression variable. In the case of Expressions, add encapsulating parenthesis to handle type casting properly. Update variable casting tests accordingly.
WyoTwT
force-pushed
the
tt_upstream_fix_casting
branch
from
97d15a1 to
511b4e9
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total removal of parenthesis removes casting parenthesis and breaks potential watch expressions so this cleanup should be removed.
Instead of calling getFullPathExpression() multiple times, built the fullPath from the topLevelExpression variable.
In the case of Expressions, add encapsulating parenthesis to handle type casting properly.
Update casting tests accordingly.