Skip to content

Do not dispatch a warning, if the git provider is not supported#1306

Merged
vinokurig merged 1 commit intomainfrom
che-23304
Feb 3, 2025
Merged

Do not dispatch a warning, if the git provider is not supported#1306
vinokurig merged 1 commit intomainfrom
che-23304

Conversation

@vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Jan 28, 2025

What does this PR do?

Do not dispatch a warning, if the git provider is not supported.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23304

Is it tested? How?

  1. Deploy Che with the pull request image: quay.io/eclipse/che-dashboard:pr-1306
  2. Start a workspace from an unsupported git provider repository e.g https://gitea.com/ivinokur/test.git

See workspace starts from the default devfile without any warnings.

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jan 28, 2025

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.60%. Comparing base (6c0d01f) to head (7ea3c7c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1306      +/-   ##
==========================================
- Coverage   91.68%   91.60%   -0.08%     
==========================================
  Files         498      499       +1     
  Lines       45447    45462      +15     
  Branches     3166     3158       -8     
==========================================
- Hits        41668    41647      -21     
- Misses       3748     3783      +35     
- Partials       31       32       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Знімок екрана 2025-01-29 о 14 34 20

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1306

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1306", name: che-dashboard}]}}]"

@vinokurig vinokurig merged commit 1635623 into main Feb 3, 2025
20 of 22 checks passed
@vinokurig vinokurig deleted the che-23304 branch February 3, 2025 15:05
@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/623: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: dashboard_3.x/623: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8699 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: sync-to-downstream_3.x/8700: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/8812 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devspacesbuild
Copy link

Build 3.19 :: operator-bundle_3.x/4394: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8700 triggered

@devstudio-release
Copy link

Build 3.19 :: copyIIBsToQuay/2907: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: dsc_3.x/2036: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: update-digests_3.x/8514: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/4394 triggered

@devspacesbuild
Copy link

Build 3.19 :: dsc_3.x/2036: SUCCESS

3.19.0-CI

@devstudio-release
Copy link

Build 3.19 :: copyIIBsToQuay/2907: SUCCESS

3.19
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.19-2
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ crwjen-3 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.19-v4.17-908442- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.19-v4.17-908442- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.19-v4.17-s390x
  + <a href=https://quay.io/devspaces/iib:3.19-v4.16-908441- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.19-v4.16-908441- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.19-v4.16-s390x
  + <a href=https://quay.io/devspaces/iib:3.19-v4.15-908440- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.19-v4.15-908440- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.19-v4.15-s390x
  + <a href=https://quay.io/devspaces/iib:3.19-v4.14-908439- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x>quay.io/devspaces/iib:3.19-v4.14-908439- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-s390x
  + quay.io/devspaces/iib:3.19-v4.14-s390x
+ x86_64-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.19-v4.17-908442- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.19-v4.17-908442- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.19-v4.17-x86_64
  + <a href=https://quay.io/devspaces/iib:3.19-v4.16-908441- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.19-v4.16-908441- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.19-v4.16-x86_64
  + <a href=https://quay.io/devspaces/iib:3.19-v4.15-908440- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.19-v4.15-908440- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.19-v4.15-x86_64
  + <a href=https://quay.io/devspaces/iib:3.19-v4.14-908439- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64>quay.io/devspaces/iib:3.19-v4.14-908439- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-x86_64
  + quay.io/devspaces/iib:3.19-v4.14-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + <a href=https://quay.io/devspaces/iib:3.19-v4.17-908442- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.19-v4.17-908442- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.19-v4.17-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.19-v4.16-908441- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.19-v4.16-908441- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.19-v4.16-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.19-v4.15-908440- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.19-v4.15-908440- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.19-v4.15-ppc64le
  + <a href=https://quay.io/devspaces/iib:3.19-v4.14-908439- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le>quay.io/devspaces/iib:3.19-v4.14-908439- /tmp/getIIBsForBundle.sh -t PROD_VER [OPTIONS]-ppc64le
  + quay.io/devspaces/iib:3.19-v4.14-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

5 participants