Fix Change of verbiage to helper text under the 'Import from Git' text box. #1311
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tyraziel The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Click here to review and test in web IDE: |
|
Hi @tyraziel. Thanks for your PR. I'm waiting for a eclipse-che member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -180,7 +180,7 @@ class ImportFromGit extends React.PureComponent<Props, State> { | |||
| validated={validated} | |||
| helperTextInvalid={errorMessage} | |||
| helperTextInvalidIcon={<ExclamationCircleIcon />} | |||
| helperText="Import from a Git repository to create your first workspace." | |||
| helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one." | |||
There was a problem hiding this comment.
@tyraziel tbh, I think the wording might be a bit confusing
There was a problem hiding this comment.
I would probably opt-for smth. more simple:
- remove mention of
devfile - remove
new / launch an existing one - replace workspace with CDE
| @@ -180,7 +180,7 @@ class ImportFromGit extends React.PureComponent<Props, State> { | |||
| validated={validated} | |||
| helperTextInvalid={errorMessage} | |||
| helperTextInvalidIcon={<ExclamationCircleIcon />} | |||
| helperText="Import from a Git repository to create your first workspace." | |||
| helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one." | |||
There was a problem hiding this comment.
| helperText="Import a devfile from a Git repository to create a new workspace or launch an existing one." | |
| helperText="Import from a Git repository to create a Cloud Development Environment" |
There was a problem hiding this comment.
I think my main hangup is that if an environment of the same name already exists, it will ask if you want to open the existing one or create a new one. Trying to capture that concisely is the tricky part.
What if we changed it from "create" to "launch"? Does launch indicate create/open?
"Import from a Git repository to launch a Cloud Development Environment"
|
@tyraziel thank you for the first contribution \o/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
- Coverage 91.68% 91.66% -0.03%
==========================================
Files 500 500
Lines 45482 45482
Branches 3164 3163 -1
==========================================
- Hits 41700 41689 -11
- Misses 3754 3764 +10
- Partials 28 29 +1 ☔ View full report in Codecov by Sentry. |
I should be all set with this. |
What does this PR do?
This PR changes the verbiage of the helper text under the Import from Git text box.
What issues does this PR fix or reference?
If you have more than zero workspaces, the verbiage doesn't make sense.
Is it tested? How?
I ran the tests from the devfile command.
Release Notes
Verbiage update on Create Workspace page.
Docs PR
N/A