-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fuse docs for Podman 5.x #2842
base: main
Are you sure you want to change the base?
Conversation
🎊 Navigate the preview: https://678ab189829fe63ea3e3a704--eclipse-che-docs-pr.netlify.app 🎊 |
c756db3
to
3df0d02
Compare
Signed-off-by: dkwon17 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of questions
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: dkwon17 <[email protected]>
@deerskindoll thank you for the review, I've made some changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I edited the doc a bit to make it easier to follow. Let me know what you think.
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/enabling-fuse-for-all-workspaces.adoc
Outdated
Show resolved
Hide resolved
…paces.adoc Co-authored-by: Jana Vrbkova <[email protected]>
…paces.adoc Co-authored-by: Jana Vrbkova <[email protected]>
…paces.adoc Co-authored-by: Jana Vrbkova <[email protected]>
Signed-off-by: dkwon17 <[email protected]>
@deerskindoll sorry for the late feedback, I've added some new comments |
For OpenShift versions 4.14 and lower, the `io.openshift.podman-fuse: ""` annotation is also required. | ||
==== | ||
|
||
. [OPTIONAL] If you are using a custom image for the workspace container, create the `/home/user/.config` folder and configure the `storage.conf` file on runtime via the entrypoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. [OPTIONAL] If you are using a custom image for the workspace container, create the `/home/user/.config` folder and configure the `storage.conf` file on runtime via the entrypoint. | |
. Optional: If you are using a custom image for the workspace container, create the `/home/user/.config` folder and configure the `storage.conf` file on runtime via the entrypoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed formatting
What does this pull request change?
This PR updates the "Enabling fuse-overlayfs for all workspaces" doc such that they work with Podman 5.x. This PR is in response to devfile/developer-images#209
What issues does this pull request fix or reference?
Related PR: devfile/developer-images#209
Specify the version of the product this pull request applies to
Che 7.95
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.