Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fuse docs for Podman 5.x #2842

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Jan 3, 2025

What does this pull request change?

This PR updates the "Enabling fuse-overlayfs for all workspaces" doc such that they work with Podman 5.x. This PR is in response to devfile/developer-images#209

What issues does this pull request fix or reference?

Related PR: devfile/developer-images#209

Specify the version of the product this pull request applies to

Che 7.95

Screenshot From 2025-01-03 14-30-11

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Copy link

github-actions bot commented Jan 3, 2025

🎊 Navigate the preview: https://678ab189829fe63ea3e3a704--eclipse-che-docs-pr.netlify.app 🎊

Copy link

github-actions bot commented Jan 3, 2025

Click here to review and test in web IDE: Contribute

@dkwon17 dkwon17 force-pushed the fuseupdate branch 3 times, most recently from c756db3 to 3df0d02 Compare January 3, 2025 16:41
@dkwon17 dkwon17 marked this pull request as ready for review January 3, 2025 19:37
@dkwon17 dkwon17 requested review from deerskindoll and a team as code owners January 3, 2025 19:37
@dkwon17 dkwon17 requested a review from nickboldt January 3, 2025 19:37
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of questions

Signed-off-by: dkwon17 <[email protected]>
@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 6, 2025

@deerskindoll thank you for the review, I've made some changes

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the doc a bit to make it easier to follow. Let me know what you think.

@dkwon17
Copy link
Contributor Author

dkwon17 commented Jan 17, 2025

@deerskindoll sorry for the late feedback, I've added some new comments

For OpenShift versions 4.14 and lower, the `io.openshift.podman-fuse: ""` annotation is also required.
====

. [OPTIONAL] If you are using a custom image for the workspace container, create the `/home/user/.config` folder and configure the `storage.conf` file on runtime via the entrypoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. [OPTIONAL] If you are using a custom image for the workspace container, create the `/home/user/.config` folder and configure the `storage.conf` file on runtime via the entrypoint.
. Optional: If you are using a custom image for the workspace container, create the `/home/user/.config` folder and configure the `storage.conf` file on runtime via the entrypoint.

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants