Patch for client connection leak when using digest authentication #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agherardi
force-pushed
the
digestAuthLeak
branch
from
e0e83be to
bed3e46
Compare
jansupol
reviewed
Jun 20, 2018
| @@ -419,4 +431,23 @@ static Credentials getCredentials(ClientRequestContext request, Credentials defa | |||
| return specificCredentials != null ? specificCredentials : defaultCredentials; | |||
| } | |||
| } | |||
|
|
|||
| private static void discardInputAndClose(InputStream is) { | |||
There was a problem hiding this comment.
This discardInputAndClose is once again in HttpAuthenticationFilter in PR3859. Can you put it to the AuthenticationUtil as discussed in PR 3862?
agherardi
force-pushed
the
digestAuthLeak
branch
from
bed3e46 to
5f4755c
Compare
Signed-off-by: agherardi <[email protected]>
agherardi
force-pushed
the
digestAuthLeak
branch
from
5f4755c to
56e58e4
Compare
Signed-off-by: agherardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clone of https://github.com/jersey/jersey/pull/3751