UI improvement, User can specify more options at memory dump analysis scene & changing setting is cancelable after open the settings pannel. #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@XuPengfei-1020 I'll review this patch this week. |
y1yang0
reviewed
Nov 30, 2023
|
Update:
We used the jifa to parse the super large dump files on linux server several times, it helpe us to location the rare memory lake point in our production environment. |
…hers additional options in dump analysis scene
…data inconsistency.
… file) after they open the setting panel in dump analysis scene.
before: dump analysis cache will dispose once user click 'Setting' button, it does not make sense.
now: dispose and re-analyse will performd sequencely only after use submit the new settings, but if user click the 'cancel' button after open the settins pannel, the pannel will closed and nothing else would happend.
…hile build frontend code
y1yang0
approved these changes
Dec 12, 2023
D-D-H
approved these changes
Dec 14, 2023
|
Merged. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. User can specify more options at memory dump analysis scene.
Analyse could be faild caused by OOM(exceed limit of maximum length of array) if the dump file is very large. This problem can be solved by specify discard-object options. see: Eclipse help .
Improve UI so user can specify those options.
2. UI improvement, user can cancel changing the settings (re-analysis dump file) after they open the setting panel in dump analysis scene.
before: dump analysis cache will dispose once user click 'Setting' button, it does not make sense.
now: dispose and re-analyse will performd sequencely only after use submit the new settings, but if user click the 'cancel' button after open the settins pannel, the pannel will closed and nothing else would happend.