Feature: JFR Visualizer #252

yanglong1010 · 2024-02-02T09:54:22Z

Hi,
The current methods for parsing JFR include Java Mission Control (desktop application), jfr (command line), and JFR.view (command line). It would be very cool to add JFR parsing capabilities to JIFA and parse JFR on the Web. It can generate flame graphs for CPU, Memory Allocation, File IO, Socket IO, Lock, Class load, Thread Sleep and other dimensions, and support filtering by threads, classes, and methods. It also supports parsing wall clock JFR files generated by async-profiler (i.e. --wall 10 -t).
In the future we can add viewing capabilities for raw JFR events, as well as other advanced features.

I would be very grateful if you could review this PR.

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/Language.java

server/src/main/java/org/eclipse/jifa/server/enums/FileType.java

frontend/vite.config.ts

…ense header "2024" to "2023, 2024" in all modified files

yanglong1010 · 2024-02-07T04:44:27Z

Thank you for your suggestions.

D-D-H · 2024-02-10T14:30:45Z

The following exception occurs (only happens when using h2 database) when I try to upload a jfr file:

org.springframework.dao.DataIntegrityViolationException: could not execute statement [Check constraint violation: "CONSTRAINT_3: "; SQL statement:
insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default) [23513-220]] [insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default)]; SQL [insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default)]; constraint ["CONSTRAINT_3: "; SQL statement:
insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default) [23513-220]]
	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.convertHibernateAccessException(HibernateJpaDialect.java:269) ~[spring-orm-6.0.12.jar:6.0.12]
	at org.springframework.orm.jpa.vendor.HibernateJpaDialect.translateExceptionIfPossible(HibernateJpaDialect.java:229) ~[spring-orm-6.0.12.jar:6.0.12]
	at org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.translateExceptionIfPossible(AbstractEntityManagerFactoryBean.java:550) ~[spring-orm-6.0.12.jar:6.0.12]
	at org.springframework.dao.support.ChainedPersistenceExceptionTranslator.translateExceptionIfPossible(ChainedPersistenceExceptionTranslator.java:61) ~[spring-tx-6.0.12.jar:6.0.12]
	at org.springframework.dao.support.DataAccessUtils.translateIfNecessary(DataAccessUtils.java:243) ~[spring-tx-6.0.12.jar:6.0.12]
	at org.springframework.dao.support.PersistenceExceptionTranslationInterceptor.invoke(PersistenceExceptionTranslationInterceptor.java:152) ~[spring-tx-6.0.12.jar:6.0.12]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.12.jar:6.0.12]
	at org.springframework.data.jpa.repository.support.CrudMethodMetadataPostProcessor$CrudMethodMetadataPopulatingMethodInterceptor.invoke(CrudMethodMetadataPostProcessor.java:164) ~[spring-data-jpa-3.1.4.jar:3.1.4]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.12.jar:6.0.12]
	at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97) ~[spring-aop-6.0.12.jar:6.0.12]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:184) ~[spring-aop-6.0.12.jar:6.0.12]
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:244) ~[spring-aop-6.0.12.jar:6.0.12]
	at jdk.proxy2/jdk.proxy2.$Proxy141.save(Unknown Source) ~[na:na]
	at org.eclipse.jifa.server.service.impl.FileServiceImpl.lambda$handleUploadRequest$3(FileServiceImpl.java:246) ~[main/:na]
	at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:140) ~[spring-tx-6.0.12.jar:6.0.12]
	at org.eclipse.jifa.server.service.impl.FileServiceImpl.handleUploadRequest(FileServiceImpl.java:239) ~[main/:na]
	at org.eclipse.jifa.server.controller.FileController.upload(FileController.java:122) ~[main/:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:na]
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[na:na]
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:na]
	at java.base/java.lang.reflect.Method.invoke(Method.java:568) ~[na:na]
	at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:205) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:150) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:118) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:884) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:797) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:87) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1081) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:974) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1011) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:914) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:590) ~[tomcat-embed-core-10.1.13.jar:6.0]
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:885) ~[spring-webmvc-6.0.12.jar:6.0.12]
	at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:658) ~[tomcat-embed-core-10.1.13.jar:6.0]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:205) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51) ~[tomcat-embed-websocket-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:174) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.eclipse.jifa.server.filter.JwtTokenRefreshFilter.doFilterInternal(JwtTokenRefreshFilter.java:47) ~[main/:na]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:174) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:131) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:85) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:100) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:179) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.oauth2.server.resource.web.authentication.BearerTokenAuthenticationFilter.doFilterInternal(BearerTokenAuthenticationFilter.java:128) ~[spring-security-oauth2-resource-server-6.1.4.jar:6.1.4]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:107) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:93) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.web.filter.CorsFilter.doFilterInternal(CorsFilter.java:91) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.header.HeaderWriterFilter.doHeadersAfter(HeaderWriterFilter.java:90) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:75) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.context.SecurityContextHolderFilter.doFilter(SecurityContextHolderFilter.java:82) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.context.SecurityContextHolderFilter.doFilter(SecurityContextHolderFilter.java:69) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:62) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.session.DisableEncodeUrlFilter.doFilterInternal(DisableEncodeUrlFilter.java:42) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:233) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:191) ~[spring-security-web-6.1.4.jar:6.1.4]
	at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:352) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:268) ~[spring-web-6.0.12.jar:6.0.12]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:174) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201) ~[spring-web-6.0.12.jar:6.0.12]
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:116) ~[spring-web-6.0.12.jar:6.0.12]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:174) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:149) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:482) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:341) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:391) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:894) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1740) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1191) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) ~[tomcat-embed-core-10.1.13.jar:10.1.13]
	at java.base/java.lang.Thread.run(Thread.java:833) ~[na:na]
Caused by: org.hibernate.exception.ConstraintViolationException: could not execute statement [Check constraint violation: "CONSTRAINT_3: "; SQL statement:
insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default) [23513-220]] [insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default)]
	at org.hibernate.exception.internal.SQLExceptionTypeDelegate.convert(SQLExceptionTypeDelegate.java:60) ~[hibernate-core-6.2.9.Final.jar:6.2.9.Final]
	at org.hibernate.exception.internal.StandardSQLExceptionConverter.convert(StandardSQLExceptionConverter.java:56) ~[hibernate-core-6.2.9.Final.jar:6.2.9.Final]
	at org.hibernate.engine.jdbc.spi.SqlExceptionHelper.convert(SqlExceptionHelper.java:108) ~[hibernate-core-6.2.9.Final.jar:6.2.9.Final]
	at org.hibernate.engine.jdbc.internal.ResultSetReturnImpl.executeUpdate(ResultSetReturnImpl.java:278) ~[hibernate-core-6.2.9.Final.jar:6.2.9.Final]
	at org.hibernate.id.insert.GetGeneratedKeysDelegate.performInsert(GetGeneratedKeysDelegate.java:107) ~[hibernate-core-6.2.9.Final.jar:6.2.9.Final]
	at org.hibernate.engine.jdbc.mutation.internal.MutationExecutorPostInsertSingleTable.execute(MutationExecutorPostInsertSingleTable.java:100) ~[hibernate-core-6.2.9.Final.jar:6.2.9.Final]
Caused by: org.hibernate.exception.ConstraintViolationException: could not execute statement [Check constraint violation: "CONSTRAINT_3: "; SQL statement:

frontend/src/i18n/en.ts

frontend/src/i18n/zh.ts

frontend/src/components/profile/Profile.vue

D-D-H · 2024-02-10T14:57:23Z

It seems like a bug.

server/src/main/java/org/eclipse/jifa/server/enums/FileType.java

frontend/src/components/profile/Profile.vue

D-D-H

Please add site documents for this feature.

yanglong1010 · 2024-02-18T08:36:32Z

The following exception occurs (only happens when using h2 database) when I try to upload a jfr file:

org.springframework.dao.DataIntegrityViolationException: could not execute statement [Check constraint violation: "CONSTRAINT_3: "; SQL statement:
insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default) [23513-220]] [insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default)]; SQL [insert into files (created_time,original_name,size,type,unique_name,user_id,id) values (?,?,?,?,?,?,default)]; constraint

Hi, DengHui

Happy Chinese New Year.

I have analyzed this problem and I estimate that it will also be encountered when adding file types in the past. The reasons are as follows.

Now in application.yml, spring.jpa.hibernate.ddl-auto=update, this configuration will automatically add fields to the table, but will not update existing constraints.
I added JFR in FileType. If the H2 file was generated before, there may not be JFR in it. You can use the following command line to open the H2 file, and then use SQL statement to check the specific content in CONSTRAINT_3.

java -cp /path/to/h2-2.2.220.jar org.h2.tools.Shell

select * from INFORMATION_SCHEMA.CHECK_CONSTRAINTS; -- no JFR
.H2DB              | PUBLIC            | CONSTRAINT_3 | "TYPE" IN('HEAP_DUMP', 'GC_LOG', 'THREAD_DUMP')

select * from INFORMATION_SCHEMA.CHECK_CONSTRAINTS; -- expected
.H2DB              | PUBLIC            | CONSTRAINT_3 | "TYPE" IN('HEAP_DUMP', 'GC_LOG', 'THREAD_DUMP', 'JFR')

The first method is to delete the old H2 file, which will be regenerated on reboot. The disadvantage is that when developers encounter this problem, they cannot directly see the cause from the logs, and it is difficult for developers to think of this method. I can add the capture of org.h2.jdbc.JdbcSQLIntegrityConstraintViolationException where the new file is added, and print information to prompt the developer to try to clean up the old H2 file.

The second method is to add an application-dev.yml file, set spring.jpa.hibernate.ddl-auto to create, and add a runStandaloneWorkerDev task. This task will delete and recreate the tables and update constraints every time it is restarted. The disadvantage is that as soon as you restart, all the previous files will disappear.

The third possible method is to retain the current spring.jpa.hibernate.ddl-auto=update. After hibernate's automatic table creation is completed, execute additional SQL files through configuration to update the constraints correctly. This method may be more complex and difficult, which is equivalent to implementing something that hibernate is currently imperfect.

Generally speaking, I recommend the first method, which is simple and effective. The second method adds extra trouble, and the third method is more difficult to implement.

May I know what you think about this issue?

D-D-H · 2024-02-19T05:46:59Z

There is a test failure:

TestProfileAnalysisApiExecutor > test() FAILED
    org.opentest4j.AssertionFailedError: expected: <jfr> but was: <jfr-file>
        at app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at app//org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
        at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
        at app//org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
        at app//org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1142)
        at app//org.eclipse.jifa.profile.TestProfileAnalysisApiExecutor.test(TestProfileAnalysisApiExecutor.java:24)

y1yang0 · 2024-02-20T06:18:12Z

Looks good in general.

Some obvious bugs:

it renders none by default, and then flamegraph appears only when we hover over empty canvas
Press [CMD] + [C] or [Ctrl] + [C] to copy method is not working the second time we try to do that

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/FileFormat.java

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/GraphType.java

analysis/profile/profile.gradle

analysis/profile/src/main/java/org/eclipse/jifa/profile/api/ProfileAnalyzer.java

analysis/profile/src/main/java/org/eclipse/jifa/profile/context/ProfileAnalysisContext.java

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/Language.java

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/ProfileFormat.java

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/Unit.java

settings.gradle

yanglong1010 · 2024-02-20T09:29:22Z

It seems like a bug.

Under investigation, seems to be related to the flame graph component

yanglong1010 · 2024-02-20T09:38:51Z

Looks good in general.

Some obvious bugs:

it renders none by default, and then flamegraph appears only when we hover over empty canvas

Press [CMD] + [C] or [Ctrl] + [C] to copy method is not working the second time we try to do that

hi y1yang0, Thanks.

bug 1: Denghui also pointed out this bug. Feature: JFR Visualizer #252 (comment), seems related to flame-graph component, I'm investigating.
bug 2: I tested it and it works fine. Friendly reminder, the mouse should keep hovering over the method to be copied.

…ve useless code

yanglong1010 · 2024-02-21T07:28:47Z

Please add site documents for this feature.

added

frontend/src/components/forms/FileTransferForm.vue

D-D-H · 2024-02-21T08:59:12Z

…, siblings[] is not cleared

yanglong1010 · 2024-02-21T11:35:03Z

pushed

yanglong1010 · 2024-02-21T11:37:03Z

It seems like a bug.

pushed

D-D-H · 2024-02-22T03:12:31Z

analysis/jfr/src/main/java/org/eclipse/jifa/jfr/vo/BasicMetadata.java

+
+@Setter
+@Getter
+public class BasicMetadata {


Rename to Metadata.

D-D-H · 2024-02-22T03:32:36Z

It would be nice if you could fix the warnings, like:

site/docs/index.md

site/docs/guide/jfr-analysis.md

site/docs/.vitepress/config.mts

site/docs/zh/guide/jfr-analysis.md

D-D-H · 2024-02-22T03:46:19Z

Hi @yanglong1010 ,

I've done a complete review. I'll approve the pr after you fix the left comments.

JFR is a very cool tool, and it's exciting that Jifa can support analyzing JFR files.

Currently, this feature only supports the performance view. We can enhance it in the future.

Thanks for the contribution.

…readPark dimensions clearer; some text changes; fix Java code warnings

yanglong1010 · 2024-02-22T08:48:46Z

@D-D-H pushed, please review again at a time convenient for you.

D-D-H

LGTM!

yanglong1010 · 2024-02-24T02:12:00Z

Thank you all.

yanglong1010 added 5 commits February 2, 2024 16:02

feature: jfr visualizer

e2d0296

Merge branch 'main' into jfr-visualizer

af419df

reformat code

2cc178d

update author

bf7bdcf

update async-profiler wall profile analysis

f7d34fe

D-D-H requested review from D-D-H and leveretconey February 3, 2024 00:03

Remove useless code; adapt async-profiler; add tests

3934155

D-D-H requested changes Feb 6, 2024

View reviewed changes

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/Language.java Outdated Show resolved Hide resolved

server/src/main/java/org/eclipse/jifa/server/enums/FileType.java Outdated Show resolved Hide resolved

frontend/vite.config.ts Outdated Show resolved Hide resolved

delete Go pprof; replace "profile" with "jfr" in FileType; change lic…

6ca7978

…ense header "2024" to "2023, 2024" in all modified files

D-D-H reviewed Feb 10, 2024

View reviewed changes

frontend/src/i18n/en.ts Outdated Show resolved Hide resolved

frontend/src/i18n/zh.ts Outdated Show resolved Hide resolved

frontend/src/components/profile/Profile.vue Outdated Show resolved Hide resolved

frontend/src/components/profile/Profile.vue Outdated Show resolved Hide resolved

D-D-H requested changes Feb 10, 2024

View reviewed changes

server/src/main/java/org/eclipse/jifa/server/enums/FileType.java Outdated Show resolved Hide resolved

frontend/src/components/profile/Profile.vue Outdated Show resolved Hide resolved

frontend/src/components/profile/Profile.vue Outdated Show resolved Hide resolved

D-D-H requested changes Feb 15, 2024

View reviewed changes

Some refactorings corresponding to code review

1aefa4d

fix test

9226713

D-D-H requested changes Feb 20, 2024

View reviewed changes

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/FileFormat.java Outdated Show resolved Hide resolved

analysis/profile/src/main/java/org/eclipse/jifa/profile/enums/GraphType.java Outdated Show resolved Hide resolved

D-D-H reviewed Feb 20, 2024

View reviewed changes

sidebar use fixed width; if no data to display, show el-empty

ee099ba

yanglong1010 and others added 4 commits February 21, 2024 11:00

use TypeAdapter for enum; rename module name "profile" to "jfr"; remo…

b3b3a07

…ve useless code

update README

a5d04f8

style: improve ui

76df045

add site documents for JFR Analysis

1fd2d34

D-D-H reviewed Feb 21, 2024

View reviewed changes

frontend/src/components/forms/FileTransferForm.vue Show resolved Hide resolved

disable upload method TEXT if file type is JFR

2704e7a

rename frontend dir to jfr; fix flame-graph component bug: if no data…

ec03feb

…, siblings[] is not cleared

D-D-H requested changes Feb 22, 2024

View reviewed changes

site/docs/index.md Outdated Show resolved Hide resolved

site/docs/guide/jfr-analysis.md Show resolved Hide resolved

site/docs/.vitepress/config.mts Outdated Show resolved Hide resolved

site/docs/zh/guide/jfr-analysis.md Outdated Show resolved Hide resolved

add underlying events to jfr-analysis.md; make Synchronization and Th…

dc3564a

…readPark dimensions clearer; some text changes; fix Java code warnings

D-D-H previously approved these changes Feb 22, 2024

View reviewed changes

rename BasicMetadata to Metadata

384d92a

yanglong1010 dismissed D-D-H’s stale review via 384d92a February 23, 2024 01:56

D-D-H approved these changes Feb 23, 2024

View reviewed changes

D-D-H merged commit 92a4445 into eclipse-jifa:main Feb 23, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: JFR Visualizer #252

Feature: JFR Visualizer #252

yanglong1010 commented Feb 2, 2024 •

edited

Loading

yanglong1010 commented Feb 7, 2024

D-D-H commented Feb 10, 2024 •

edited

Loading

D-D-H commented Feb 10, 2024

D-D-H left a comment

yanglong1010 commented Feb 18, 2024 •

edited

Loading

D-D-H commented Feb 19, 2024

y1yang0 commented Feb 20, 2024

yanglong1010 commented Feb 20, 2024

yanglong1010 commented Feb 20, 2024

yanglong1010 commented Feb 21, 2024

D-D-H commented Feb 21, 2024

yanglong1010 commented Feb 21, 2024

yanglong1010 commented Feb 21, 2024

D-D-H Feb 22, 2024

D-D-H commented Feb 22, 2024

D-D-H commented Feb 22, 2024

yanglong1010 commented Feb 22, 2024

D-D-H left a comment

yanglong1010 commented Feb 24, 2024

Feature: JFR Visualizer #252

Feature: JFR Visualizer #252

Conversation

yanglong1010 commented Feb 2, 2024 • edited Loading

yanglong1010 commented Feb 7, 2024

D-D-H commented Feb 10, 2024 • edited Loading

D-D-H commented Feb 10, 2024

D-D-H left a comment

Choose a reason for hiding this comment

yanglong1010 commented Feb 18, 2024 • edited Loading

D-D-H commented Feb 19, 2024

y1yang0 commented Feb 20, 2024

yanglong1010 commented Feb 20, 2024

yanglong1010 commented Feb 20, 2024

yanglong1010 commented Feb 21, 2024

D-D-H commented Feb 21, 2024

yanglong1010 commented Feb 21, 2024

yanglong1010 commented Feb 21, 2024

D-D-H Feb 22, 2024

Choose a reason for hiding this comment

D-D-H commented Feb 22, 2024

D-D-H commented Feb 22, 2024

yanglong1010 commented Feb 22, 2024

D-D-H left a comment

Choose a reason for hiding this comment

yanglong1010 commented Feb 24, 2024

yanglong1010 commented Feb 2, 2024 •

edited

Loading

D-D-H commented Feb 10, 2024 •

edited

Loading

yanglong1010 commented Feb 18, 2024 •

edited

Loading