-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(output): exit simulation if output configuration is erroneous #478
base: main
Are you sure you want to change the base?
Conversation
05703f7
to
506316b
Compare
506316b
to
fe80ad2
Compare
Todo: check that it is OK if there's no |
Would it make sense then to have the output ambassador activated? What happens now if no output_config is given? |
Ah true, I didn't think of that option! Currently we have a slightly misleading error if the file is missing but the output generator is enabled:
I will think of a solution and propose one. .... thinking of it: The root cause (second error) is very explicit. Maybe that's enough... lets see. |
cc03ae4
to
fc954fc
Compare
fc954fc
to
19b0d92
Compare
Description
Changes the error handling into the direction of "fail early and hard" when the output is not well configured. This might lead to bigger discussions in the group, but I think
Issue(s) related to this PR
Affected parts of the online documentation
No
Changes in the documentation required?
Definition of Done
Prerequisites
Required
type(scope): description
(in the style of Conventional Commits)enhancement
, orbugfix
)origin/main
has been merged into your Fork.Requested (can be enforced by maintainers)
Special notes to reviewer