Skip to content

Replace deprecated asLocalURL with toFileURL #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Apr 17, 2025

This PR Updates the code to use FileLocator.toFileURL instead of the old Platform.asLocalURL, thus removing the use of a deprecated API for a more cleaner usage.

Replaces the old URL handling system with FileLocator.toFileURL to eliminate dependency on deprecated API.
Copy link
Contributor

github-actions bot commented Apr 17, 2025

Test Results

0 files   -  1 824  0 suites   - 1 824   0s ⏱️ - 1h 37m 15s
0 tests  -  7 918  0 ✅  -  7 690  0 💤  - 228  0 ❌ ±0 
0 runs   - 23 841  0 ✅  - 23 093  0 💤  - 748  0 ❌ ±0 

Results for commit 2eadba6. ± Comparison against base commit 766f285.

♻️ This comment has been updated with latest results.

@elsazac elsazac force-pushed the replaceasLocalURL branch 2 times, most recently from b6355ca to 5cd17e3 Compare April 23, 2025 07:40
@elsazac
Copy link
Member Author

elsazac commented Apr 23, 2025

The build looks good; I intend to merge this if no objections.

@iloveeclipse
Copy link
Member

@elsazac : please don't use merge commits. It is forbidden for platform. Rebase your code on top of master instead.

@elsazac
Copy link
Member Author

elsazac commented Apr 23, 2025

@elsazac : please don't use merge commits. It is forbidden for platform. Rebase your code on top of master instead.

Yes, got it. Sorry about that—there was an issue with my rebase, and it ended up involving merge commits.

@elsazac elsazac force-pushed the replaceasLocalURL branch from 1e2da33 to 2eadba6 Compare April 24, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants