Skip to content

Use on-the-fly disabled icons in several bundles #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

HeikoKlare
Copy link
Contributor

This replaces the usage of pre-generated disabled icons in different bundles. Most of the images / image descriptors were not reused anyway, so setting them at different actions is simply removes. Some shared image descriptors are adapted to generate the disabled version of the shared icon programmatically.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.tests.views.properties.tabbed/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 726207aa3f9e2e0c598160258cf191d44b0ef82e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sat, 26 Apr 2025 18:04:58 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/tests/org.eclipse.ui.tests.views.properties.tabbed/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.tests.views.properties.tabbed/META-INF/MANIFEST.MF
index fa91168a54..1365c01fc7 100644
--- a/tests/org.eclipse.ui.tests.views.properties.tabbed/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.tests.views.properties.tabbed/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.tests.views.properties.tabbed;singleton:=true
-Bundle-Version: 3.8.400.qualifier
+Bundle-Version: 3.8.500.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.ui,
  org.eclipse.core.runtime,
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Apr 26, 2025

Test Results

 1 523 files  ±0   1 523 suites  ±0   1h 15m 3s ⏱️ - 2m 3s
 7 918 tests ±0   7 688 ✅ ±0  229 💤 ±0  0 ❌ ±0  1 🔥 ±0 
22 184 runs  ±0  21 630 ✅ ±0  553 💤 ±0  0 ❌ ±0  1 🔥 ±0 

For more details on these errors, see this check.

Results for commit a4ff4ae. ± Comparison against base commit 6bb99bb.

♻️ This comment has been updated with latest results.

HeikoKlare and others added 2 commits April 27, 2025 12:14
This replaces the usage of pre-generated disabled icons in different
bundles. Most of the images / image descriptors were not reused anyway,
so setting them at different actions is simply removes. Some shared
image descriptors are adapted to generate the disabled version of the
shared icon programmatically.
@HeikoKlare
Copy link
Contributor Author

Failing test is unrelated and what introduced by: #2899

@HeikoKlare HeikoKlare merged commit 4fa1eee into eclipse-platform:master Apr 27, 2025
9 of 11 checks passed
@HeikoKlare HeikoKlare deleted the disabled-remaining branch April 27, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants