Replace PROJECT_OPEN_NEW_PERSPECTIVE Constant with IDE.Preferences Equivalent #2971
Conversation
| @@ -12,7 +12,8 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)", | |||
| org.eclipse.swt;bundle-version="[3.128.0,4.0.0)";visibility:=reexport, | |||
| org.eclipse.jface;bundle-version="[3.34.0,4.0.0)";visibility:=reexport, | |||
| org.eclipse.ui.workbench;bundle-version="[3.130.0,4.0.0)";visibility:=reexport, | |||
| org.eclipse.core.expressions;bundle-version="[3.4.0,4.0.0)" | |||
| org.eclipse.core.expressions;bundle-version="[3.4.0,4.0.0)", | |||
| org.eclipse.ui.ide;bundle-version="3.22.600" | |||
There was a problem hiding this comment.
This adds cyclic dependency
There was a problem hiding this comment.
Is the presence of cyclic dependencies discouraged ?; is it okay to add the bundle requirement in the Import-Package instead?
There was a problem hiding this comment.
I don't think we would want to make an IDE-independent part depend on the IDE all of a sudden, even if it were allowed (and it's not allowed.)
There was a problem hiding this comment.
@merks Do you have any suggestions to go about this fix?
|
Maybe the deprecated addition (from 2004) should finally be removed from the preferences initializer?
|
Can this be removed now? , as the effective preference used by the Eclipse IDE is the one under org.eclipse.ui.ide, not the one in org.eclipse.ui? I don’t think the deprecated one (IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE) no longer influences current project-opening behaviour. |
|
Yes I doubt it’s relevant |
elsazac
force-pushed
the
UseIDEPref
branch
2 times, most recently
from
ba478d0 to
06018c8
Compare
I’ve pushed the changes again — is this good to go now? |
in IWorkbenchPreferenceConstants interface is deprecated and marked for removal and hence it can be replaced with public static final String PROJECT_OPEN_NEW_PERSPECTIVE = "PROJECT_OPEN_NEW_PERSPECTIVE" present in IDE.Preferences. Fixup : effective preference used by the Eclipse IDE is the one under org.eclipse.ui.ide, not the one in org.eclipse.ui. deprecated IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE no longer influences current project-opening behaviour.
The effective preference used by Eclipse is now under
org.eclipse.ui.ide.The deprecated constant (
IWorkbenchPreferenceConstants.PROJECT_OPEN_NEW_PERSPECTIVE)from
org.eclipse.uino longer affects the current project-opening behavior.