Converting Support tray to use Image with constructor that utilizes imageGCDrawer instead of imageData

[arunjose696]

The SupportTray class previously used the Image(Device, ImageData) constructor to draw the close button on the ToolBar positioned alongside the support tray.

This PR modifies SupportTray to use the Image constructor that utilizes ImageGCDrawer instead of ImageData, since scaling ImageData is a destructive operation.

Triggering a supporttray is not so straight forward in runtime workspace. To test this implementation, the following example can be used. It simply opens a support tray with a toolbar and waits for it to be closed.

package org.eclipse.swt.snippets;


import java.util.*;

import org.eclipse.core.runtime.*;
import org.eclipse.jface.dialogs.*;
import org.eclipse.swt.widgets.*;
import org.eclipse.ui.internal.statushandlers.*;
import org.eclipse.ui.statushandlers.*;

public class SupportTrayExample {

	public static void main(String[] args) {
		Display display = new Display();
		Shell shell = new Shell(display);

		final TrayDialog[] td = new TrayDialog[1];
		try {
			td[0] = new TrayDialog(shell) {
				
			};

			Map<Object, Object> dialogState = new HashMap<>();
			dialogState.put(IStatusDialogConstants.CURRENT_STATUS_ADAPTER, new StatusAdapter(Status.OK_STATUS));

			SupportTray supportTray = new SupportTray(dialogState, event -> td[0].closeTray());

			td[0].setBlockOnOpen(false);
			td[0].open();
			td[0].openTray(supportTray);

			
			while (!shell.isDisposed()) {
				if (!display.readAndDispatch()) {
					display.sleep();
				}
			}
		} finally {
			display.dispose();
		}
	}
}

Note To run this example, you may need to temporarily add the following to the MANIFEST.MF file in the org.eclipse.swt.snippets project:

Require-Bundle: org.eclipse.swt,
 org.eclipse.core.runtime,
 org.eclipse.jface,
 org.eclipse.ui.workbench

Alternatively, you can fix the project setup by following the error prompts in the IDE for this example.

[arunjose696]

The setBackground call on the image has been omitted because it has no visible impact; the GC sets the image background to transparent.

[github-actions]

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 39m 50s ⏱️ +31s
 7 925 tests ±0   7 697 ✅ +1  228 💤 ±0  0 ❌  - 1 
23 328 runs  +4  22 582 ✅ +5  746 💤 ±0  0 ❌  - 1 

Results for commit 8f317be. ± Comparison against base commit ef9a336.

♻️ This comment has been updated with latest results.

[fedejeanne]

I drafted this PR because it contains a commit that shall not be merged. I use that commit to start the checks in our organization: vi-eclipse.

@arunjose696 once your PR is ready to be reviewed and merged, please rebase on origin/master (the official repository) and push. This will get rid of the extra commit.

[arunjose696]

@arunjose696 once your PR is ready to be reviewed and merged, please rebase on origin/master (the official repository) and push. This will get rid of the extra commit.

Done

[fedejeanne]

Workflows approved

[amartya4256]

The code in itself looks good and I have also tested the behaviour and it seems to not change anything visually but it rather has a functional impact over SupportTray by using GcDrawer instead of ImageData to create the close button which provides a better scaling as compared to while using ImageData. I have a nit-picky suggestion to add on tops.

I think the commit title can be re-phrased: Use GcDrawer instead of ImageData for SupportTray images

[arunjose696]

I think the commit title can be re-phrased: Use GcDrawer instead of ImageData for SupportTray images

Done