Skip to content

Fix NPE when viewer control doesn't adapt to CompareConfiguration #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025

Conversation

jonahgraham
Copy link
Contributor

Follow up to #2629

which introduced an NPE when doing refactor->rename in CDT: eclipse-cdt/cdt#1172

Follow up to
eclipse-platform#2629

which introduced an NPE when doing refactor->rename in CDT:
eclipse-cdt/cdt#1172
Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you wish to merge this for RC2

A null guard seems 100% safe, so consider it PMC +1 approved.

Copy link
Contributor

Test Results

 1 824 files  ±0   1 824 suites  ±0   1h 38m 54s ⏱️ - 4m 2s
 7 925 tests ±0   7 697 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 862 runs  ±0  23 114 ✅ ±0  748 💤 ±0  0 ❌ ±0 

Results for commit 96c4bed. ± Comparison against base commit b141132.

@HeikoKlare HeikoKlare merged commit 22ec1e2 into eclipse-platform:master May 28, 2025
18 checks passed
@jonahgraham
Copy link
Contributor Author

Thanks for merging this.

@jonahgraham jonahgraham deleted the npe branch May 28, 2025 22:42
@HeikoKlare HeikoKlare added this to the 4.36 RC2 milestone May 29, 2025
@HeikoKlare
Copy link
Contributor

fyi: "luckily" the regular I-Build last night failed due to a short infrastructure hickup. I restarted it after merging this one, so it still went into the build supposed to be contributed for RC2: eclipse-platform/eclipse.platform.releng.aggregator#3068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants