Skip to content

[#2909] fix wrong hover size in composite hovers #3056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ghentschke
Copy link
Contributor

These two changes require each other:

  • Do not add sizes in computeCompositeSize as only the max. should be used in x-direction

  • Prevent shrinking of the hover shell when the size calculation fails

fixes #2909

These two changes require each other:

* Do not add sizes in computeCompositeSize as only the max. should be
used in x-direction

* Prevent shrinking of the hover shell when the size calculation fails

fixes eclipse-platform#2909
@ghentschke
Copy link
Contributor Author

ghentschke commented Jun 20, 2025

This change will lead to this composite hover to be displayed (combination of: MarkerInformationControl, FocusableBrowserInformationControl and DefaultInformationControl):

image

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From c13b4c33eea88211a590124506d970797302af6a Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Fri, 20 Jun 2025 07:58:45 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
index 1a26692dbe..d7a202bda7 100644
--- a/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.genericeditor/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.ui.genericeditor;singleton:=true
-Bundle-Version: 1.3.600.qualifier
+Bundle-Version: 1.3.700.qualifier
 Bundle-Vendor: %Bundle-Vendor
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.ui.workbench.texteditor;bundle-version="3.10.0",
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 2 778 files  ±0   2 778 suites  ±0   1h 42m 52s ⏱️ + 3m 53s
 7 928 tests ±0   7 700 ✅ ±0  228 💤 ±0  0 ❌ ±0 
23 337 runs  ±0  22 591 ✅ ±0  746 💤 ±0  0 ❌ ±0 

Results for commit 68df7a5. ± Comparison against base commit ca63f41.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven "pom.xml": popup for validation warning has wrong size
2 participants