Create copilot.aggrcon #974
Conversation
copilot.aggrcon
Outdated
| @@ -0,0 +1,9 @@ | |||
| <?xml version="1.0" encoding="ASCII"?> | |||
| <aggregator:Contribution xmi:version="2.0" xmlns:xmi="http://www.omg.org/XMI" xmlns:aggregator="http://www.eclipse.org/cbi/p2repo/2011/aggregator/1.1.0" label="Copilot"> | |||
| <repositories location="https://azuredownloads-g3ahgwb5b8bkbxhd.b01.azurefd.net/eclipse-copilot-repository"> | |||
There was a problem hiding this comment.
I just update the folder structure to reflect the version, please use this one: https://azuredownloads-g3ahgwb5b8bkbxhd.b01.azurefd.net/eclipse-copilot-repository/staging/0.10.1
Thank you!
There was a problem hiding this comment.
This repository still has the license problem:
Can you build a new version with the license fixed?
There was a problem hiding this comment.
Yes, I'm building it, should be available after ~30-45 mins
There was a problem hiding this comment.
Pls try again, it includes both license change and the p2.inf update
There was a problem hiding this comment.
That's better:
But this also suggests that you are over writing the content at the existing location which in general is a formula for problems. It mean from one minute the next, the aggregated contents might be different with no actual change to the modeled contributions. So someone might update their contribution and then the build might fail because of something you've changed in your repository. (This is less likely because there are no dependency on copilot.)
What are the project's plans for how update sites are managed to provide stable/unchanging milestones and releases?
There was a problem hiding this comment.
When is CDT planning to contribute for M3? I see there are some dependencies on content provided by CDT and I don't want there to be problems related to that should the CDT migrate more fully to the org.eclipse.terminal stack:
Of course we'll have other problems with TCF and PHP if that's the case:
There was a problem hiding this comment.
I have put in M3 - but there is no differences here.
I tried using the migration path that @laeubi wrote in eclipse-cdt/cdt#1259 but it isn't ready yet.
This means we still need two versions of the terminal - at least for now.
Ok, so does that mean, we should put different bits into different locations. And when a newer update site is available, I need to create a PR here to update the URL? |
|
Maybe have a look at what this describes: https://eclipse.dev/justj/?page=tools It's used to produce update sites like these: https://download.eclipse.org/justj/jres/21/updates/ The Platform does it differently, but the idea is the same. https://download.eclipse.org/eclipse/updates/4.37-I-builds/ So yes, each build produces a new update site, e.g., https://download.eclipse.org/modeling/emf/emf/builds/milestone/S202508121310 In addition there are composites that maintain a "link" to the latest site: https://download.eclipse.org/modeling/emf/emf/builds/milestone/latest This is why I asked this (unanswered) question weeks ago: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/6450#note_4634622 I'm not sure if https://eclipse.dev/justj/?page=tools can be reused to produce what you publish you current location? It uses |
|
As a proof of concept, I created this job: https://ci.eclipse.org/oomph/job/copilot-mirror/ It's based on the content in this folder: https://github.com/eclipse-oomph/oomph.incubator/tree/master/copilot It produces this update site: https://download.eclipse.org/oomph/copilot/ And the report shows they are signed by oomph-dev: 
So as an interim step I would build a site that is stable using this approach. |
|
For the update site, I assume each eclipse project can have their own download site hosted by eclipse? I filed a ticket to request one for copilot plugin. |
|
When you have a "final" state of your repository ready for contribution for M3 (i.e., one with source bundles and your branding plugin) please let me know. I could then incorporate it into the following location as a milestone build so that we have a stable source until an RC1 contribution is available: https://download.eclipse.org/oomph/copilot/ Is that okay? We have until the end of the day tomorrow if you are doing some last-minute improvements. |
Here it is: https://azuredownloads-g3ahgwb5b8bkbxhd.b01.azurefd.net/eclipse-copilot-repository/staging/0.10.1 I know that the folder structure is not following the convention. Let's use it as a workaround before we settle down the download server provisioning. I will guarantee that this update site will be persisted for a long time. |
|
FYI, I consider the issue opened by Wayne to be a blocker for this PR: |
|
We are talking with github about the license. |
3 participants
No description provided.