Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fix-path in non-bundled environments #14819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

msujew
Copy link
Member

@msujew msujew commented Feb 3, 2025

What it does

Closes #14804

Adjusts the import of fix-path to ensure that it also works in non-bundled environments.

How to test

  1. Adjust the electron test app: Replace the main entry in the package.json with "src-gen/backend/electron-main.js".
  2. Run npm run build:electron && npm run start:electron
  3. The app still doesn't start due to other ESM dependencies, but at least it gets to import them ¯\_(ツ)_/¯

Follow-ups

We should switch to ESM modules in our app.

Review checklist

Reminder for reviewers

@msujew msujew requested a review from tsmaeder February 3, 2025 11:56
@msujew msujew force-pushed the msujew/fix-path-nr2 branch from d5356ac to 575e3e7 Compare February 4, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

The generated sample Electron app crashes on startup
1 participant