Fix webpack watching #14844
Merged
Fix webpack watching #14844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
approved these changes
Feb 5, 2025
dev-packages/native-webpack-plugin/src/native-webpack-plugin.ts
Outdated
Show resolved
Hide resolved
msujew
force-pushed
the
msujew/fix-watch
branch
from
78bc6e2 to
49efae1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #14843
It seems like with a recent webpack upgrade, the watching behavior changed. This change only writes changes to the replacement files in case the file content differs from disk. Otherwise, the contents stay as they are.
How to test
Run
npm run watch:browser. Assert that it doesn't run into an infinite loop.Review checklist
Reminder for reviewers