Align AI chat toggle keybinding with VS Code on macOS #14850
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, assign Control+Command+I keybinding and on other platforms Control+Alternate+I to align with VS Code on Mac and not clash with Chrome devtools on all platforms. Fixes eclipse-theia#14814 Signed-off-by: Christian W. Damus <[email protected]>
JonasHelming
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks, LGTM (on Linux)
@kittaakos Could you confirm this solves your issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
On macOS, assign
Control+Command+Ikeybinding and on other platformsControl+Alternate+Ito align with VS Code on Mac and not clash with Chrome devtools on all platforms.Fixes #14814
How to test
Review the keybinding editor. On macOS, you should see something like this (never mind that Theia shows the modifiers in the wrong order):
Follow-ups
None.
Breaking changes
None.
Attribution
None.
Review checklist
Reminder for reviewers