Open
Conversation
5f36177 to
9115c0f
Compare
reuterbal
requested changes
Oct 14, 2025
Collaborator
reuterbal
left a comment
There was a problem hiding this comment.
No objections to keeping this around for a while. Am I understanding correctly that this is a kind of halfway-house between the ecrad_ifs and ecrad_ifs_blocked drivers, with blocked allocations but avoiding the slices out of a single allocation?
Ideally, we should add this driver to the Ctest definitions so tests are being run for it, too. Could you add it to the list of drivers in these two places?
…this version but it will be use to have around for a while.
9115c0f to
1edc467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version of the driver I wrote which I've been using for validation. Ultimately, we may not want to keep this but it may be useful for a while as we attempt to make the OpenMP version portable.