Fix NVHPC compilation for master-omp#88
Merged
reuterbal merged 2 commits intomaster-ompfrom Oct 28, 2025
Merged
Conversation
Collaborator
Author
|
@PaulMullowney does this look sane to you? |
Yes, it looks good. I've actually run in to this before with NVCOMPILER though I don't recall if it was a compile time or run time issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ifsrrtm was not using OpenMP because there is no CPU-side OpenMP code in there. For GPU execution we have offload directives and therefore need to make sure we link against that target.
That unearthed the fact that NVHPC seems to not support the PRESENT modifier in MAP: