Dataflow Analysis Refactor#521
Open
Andrew-Beggs-ECMWF wants to merge 10 commits intoecmwf-ifs:mainfrom
Open
Conversation
This commit adds AbstractDFA and the concrete implementation of LiveVariableAnalysis. LiveVariableAnalysis replaces DataFlowAnalysis, and is simply a rename from the user's perspective. Internally, everything has been brought under one class (with the use of inner classes) and makes use of AbstractDFA. The goal is that other forms of DFA will follow and use this pattern as a common interface.
This is to better reflect existing patterns & functionality.
ConstantPropagationAnalysis.py -> constant_propagation_analysis AbstractDFA.py -> abstract_dfa.py DataFlowAnalysis.py -> data_flow_analysis.py
Andrew-Beggs-ECMWF
force-pushed
the
naab-dfa-refactor
branch
from
a4eb496 to
cad4be5
Compare
Collaborator
|
Thanks @Andrew-Beggs-ECMWF, please mark this as ready for review if you think we should have a look. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #521 +/- ##
==========================================
- Coverage 96.12% 96.12% -0.01%
==========================================
Files 232 233 +1
Lines 41507 41524 +17
==========================================
+ Hits 39900 39916 +16
- Misses 1607 1608 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I've marked it ready for review as I think the technical side of things is ready. I've still to add the docstrings though, I might wait until you've made suggestions so I'm not rewriting them if something changes : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off of #515 and implemented suggested changes.
This PR refactors dataflow analysis into a framework that can handle multiple kinds of analysis.