Skip to content

Loki: Bug fixing on _get_procedure_item #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rommelDB wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Loki: Bug fixing on _get_procedure_item #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions loki/batch/item_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,16 +542,16 @@ def _get_procedure_item(self, proc_symbol, scope_ir, config, ignore=None):
if unqualified_imports:
# We try to find the ProcedureItem in the unqualified module imports
module_names = [imprt.module for imprt in unqualified_imports]
candidates = self.get_or_create_module_definitions_from_candidates(
candidates = set(self.get_or_create_module_definitions_from_candidates(
proc_name, config, module_names=module_names, only=ProcedureItem
)
))
if candidates:
if len(candidates) > 1:
candidate_modules = [it.scope_name for it in candidates]
raise RuntimeError(
f'Procedure {item_name} defined in multiple imported modules: {", ".join(candidate_modules)}'
f'Procedure {proc_name} defined in multiple imported modules: {", ".join(candidate_modules)}'
)
return candidates[0]
return list(candidates)[0]

# This is a call to a subroutine declared via header-included interface
item_name = f'#{proc_name}'.lower()
Expand Down
Loading