Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COPDS-2331 #136

Merged
merged 7 commits into from
Jan 10, 2025
Merged

COPDS-2331 #136

merged 7 commits into from
Jan 10, 2025

Conversation

malmans2
Copy link
Member

No description provided.

@malmans2 malmans2 marked this pull request as ready for review December 27, 2024 10:01
@EddyCMWF
Copy link
Contributor

EddyCMWF commented Jan 8, 2025

small comment, would in_place be better that terminology than frozen

Will deploy on my ceph-fs dev stack to test with cads-adaptors before I submit a full review

@malmans2
Copy link
Member Author

malmans2 commented Jan 8, 2025

Sure, if you think InPlaceFile is better, that works for me.

@malmans2 malmans2 mentioned this pull request Jan 8, 2025
Closed
@EddyCMWF EddyCMWF self-requested a review January 10, 2025 08:23
EddyCMWF
EddyCMWF approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@EddyCMWF EddyCMWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the unit tests a failing

@malmans2
Copy link
Member Author

malmans2 commented Jan 10, 2025 •
edited
Loading

Yes, probably unrelated. I guess it's triggered by the latest release of xarray (yesterday).
I'll check later, and will open a separate PR if that's the problem.

@malmans2
Copy link
Member Author

Actually, the problem comes from the release of zarr 3.0
We don't use caching to zarr at the moment, so let's merge this. I will investigate in the next few days if this does not get fixed upstream.

@malmans2 malmans2 merged commit 5ae1aa5 into main Jan 10, 2025
8 of 9 checks passed
@malmans2 malmans2 deleted the COPDS-2331 branch January 10, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddyCMWF EddyCMWF EddyCMWF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malmans2 @EddyCMWF