Skip to content

Conversation

javak87
Copy link
Contributor

@javak87 javak87 commented Oct 6, 2025

Description

Add more modules to annotation.json for profiling.

Issue Number

Closes #1032

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@javak87 javak87 marked this pull request as draft October 6, 2025 08:26
@javak87 javak87 marked this pull request as ready for review October 6, 2025 08:28
@tjhunter tjhunter merged commit d0e103e into ecmwf:develop Oct 13, 2025
5 checks passed
sophie-xhonneux pushed a commit that referenced this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

annotations.json need to be updated

2 participants